AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

misc: fastrpc: add checked value for dma_set_mask

Browse Source 
There be should check return value from dma_set_mask to throw some info
if fail to set dma mask.

Detected by CoverityScan, CID# 1443983:  Error handling issues (CHECKED_RETURN)

Fixes: f6f9279f2b ("misc: fastrpc: Add Qualcomm fastrpc basic driver model")
Signed-off-by: Bo YU <tsu.yubo@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Bo YU 2019-03-28 03:47:37 -04:00 committed by Greg Kroah-Hartman
parent c24b074cfd
commit 01b76c32e3
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/misc/fastrpc.c
View File

@ -1184,6 +1184,7 @@ static int fastrpc_cb_probe(struct platform_device *pdev)
struct fastrpc_session_ctx *sess; struct fastrpc_session_ctx *sess;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
int i, sessions = 0; int i, sessions = 0;
int rc;
cctx = dev_get_drvdata(dev->parent); cctx = dev_get_drvdata(dev->parent);
if (!cctx) if (!cctx)
@ -1213,7 +1214,11 @@ static int fastrpc_cb_probe(struct platform_device *pdev)
} }
cctx->sesscount++; cctx->sesscount++;
spin_unlock(&cctx->lock); spin_unlock(&cctx->lock);
dma_set_mask(dev, DMA_BIT_MASK(32)); rc = dma_set_mask(dev, DMA_BIT_MASK(32));
if (rc) {
dev_err(dev, "32-bit DMA enable failed\n");
return rc;
}
return 0; return 0;
} }