AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

dlm: fix uninitialized variable for search_rsb_list callers

Browse Source 
gcc 4.3.0 correctly emits the following warning.
search_rsb_list does not *r_ret if no dlm_rsb is found
and _search_rsb may pass the uninitialized value upstream
on the error path when both calls to search_rsb_list
return non-zero error.

The fix sets *r_ret to NULL on search_rsb_list's not-found path.

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: David Teigland <teigland@redhat.com>
This commit is contained in:
Benny Halevy 2008-06-30 19:59:14 +03:00 committed by David Teigland
parent 311f6fc77c
commit 18c60c0a3b
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
fs/dlm/lock.c
View File

@ -363,6 +363,7 @@ static int search_rsb_list(struct list_head *head, char *name, int len,
if (len == r->res_length && !memcmp(name, r->res_name, len)) if (len == r->res_length && !memcmp(name, r->res_name, len))
goto found; goto found;
} }
*r_ret = NULL;
return -EBADR; return -EBADR;
found: found: