batman-adv: Fix check of retrieved orig_gw in batadv_v_gw_is_eligible

The batadv_v_gw_is_eligible function already assumes that orig_node is not
NULL. But batadv_gw_node_get may have failed to find the originator. It
must therefore be checked whether the batadv_gw_node_get failed and not
whether orig_node is NULL to detect this error.

Fixes: 50164d8f50 ("batman-adv: B.A.T.M.A.N. V - implement GW selection logic")
Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
Acked-by: Antonio Quartulli <a@unstable.cc>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
This commit is contained in:
Sven Eckelmann 2017-11-29 10:50:42 +01:00 committed by Simon Wunderlich
parent fe77d8257c
commit 198a62ddff

View File

@ -814,7 +814,7 @@ static bool batadv_v_gw_is_eligible(struct batadv_priv *bat_priv,
} }
orig_gw = batadv_gw_node_get(bat_priv, orig_node); orig_gw = batadv_gw_node_get(bat_priv, orig_node);
if (!orig_node) if (!orig_gw)
goto out; goto out;
if (batadv_v_gw_throughput_get(orig_gw, &orig_throughput) < 0) if (batadv_v_gw_throughput_get(orig_gw, &orig_throughput) < 0)