forked from luck/tmp_suning_uos_patched
ipv4: fib: use struct_size() in kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; struct boo entry[]; }; instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL); Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper: instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
ee69804714
commit
1f533ba6d5
|
@ -1072,7 +1072,7 @@ struct fib_info *fib_create_info(struct fib_config *cfg,
|
||||||
goto failure;
|
goto failure;
|
||||||
}
|
}
|
||||||
|
|
||||||
fi = kzalloc(sizeof(*fi)+nhs*sizeof(struct fib_nh), GFP_KERNEL);
|
fi = kzalloc(struct_size(fi, fib_nh, nhs), GFP_KERNEL);
|
||||||
if (!fi)
|
if (!fi)
|
||||||
goto failure;
|
goto failure;
|
||||||
fi->fib_metrics = ip_fib_metrics_init(fi->fib_net, cfg->fc_mx,
|
fi->fib_metrics = ip_fib_metrics_init(fi->fib_net, cfg->fc_mx,
|
||||||
|
|
Loading…
Reference in New Issue
Block a user