net: tipc: fix a missing check of nla_nest_start

nla_nest_start could fail and requires a check. The fix returns
-EMSGSIZE if it fails.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Kangjie Lu 2019-03-15 12:11:59 -05:00 committed by David S. Miller
parent 07660ca679
commit 4589e28db4

View File

@ -919,6 +919,9 @@ int tipc_group_fill_sock_diag(struct tipc_group *grp, struct sk_buff *skb)
{ {
struct nlattr *group = nla_nest_start(skb, TIPC_NLA_SOCK_GROUP); struct nlattr *group = nla_nest_start(skb, TIPC_NLA_SOCK_GROUP);
if (!group)
return -EMSGSIZE;
if (nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_ID, if (nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_ID,
grp->type) || grp->type) ||
nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_INSTANCE, nla_put_u32(skb, TIPC_NLA_SOCK_GROUP_INSTANCE,