AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

gdbstub: Replace strcpy() by strscpy()

Browse Source 
The strcpy() function is being deprecated. Replace it by the safer
strscpy() and fix the following Coverity warning:

"You might overrun the 1024-character fixed-size string remcom_in_buffer
by copying cmd without checking the length."

Addresses-Coverity-ID: 138999 ("Copy into fixed size buffer")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
This commit is contained in:
Gustavo A. R. Silva 2019-04-22 11:33:42 -05:00 committed by Daniel Thompson
parent a5d5092c92
commit 4cc168eaf3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/debug/gdbstub.c
View File

@ -1095,10 +1095,10 @@ int gdbstub_state(struct kgdb_state *ks, char *cmd)
return error; return error;
case 's': case 's':
case 'c': case 'c':
strcpy(remcom_in_buffer, cmd); strscpy(remcom_in_buffer, cmd, sizeof(remcom_in_buffer));
return 0; return 0;
case '$': case '$':
strcpy(remcom_in_buffer, cmd); strscpy(remcom_in_buffer, cmd, sizeof(remcom_in_buffer));
gdbstub_use_prev_in_buf = strlen(remcom_in_buffer); gdbstub_use_prev_in_buf = strlen(remcom_in_buffer);
gdbstub_prev_in_buf_pos = 0; gdbstub_prev_in_buf_pos = 0;
return 0; return 0;