AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

UBI: fix error return code

Browse Source 
Set the return variable to an error code as done elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Richard Weinberger <richard@nod.at>
This commit is contained in:
Julia Lawall 2013-12-29 23:47:19 +01:00 committed by Artem Bityutskiy
parent 802eee95bd
commit 4d525145a6
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/mtd/ubi/attach.c
View File

@ -1453,8 +1453,10 @@ int ubi_attach(struct ubi_device *ubi, int force_scan)
struct ubi_attach_info *scan_ai; struct ubi_attach_info *scan_ai;
scan_ai = alloc_ai("ubi_ckh_aeb_slab_cache"); scan_ai = alloc_ai("ubi_ckh_aeb_slab_cache");
if (!scan_ai) if (!scan_ai) {
err = -ENOMEM;
goto out_wl; goto out_wl;
}
err = scan_all(ubi, scan_ai, 0); err = scan_all(ubi, scan_ai, 0);
if (err) { if (err) {

4
drivers/mtd/ubi/build.c
View File

@ -1245,8 +1245,10 @@ static int __init ubi_init(void)
ubi_wl_entry_slab = kmem_cache_create("ubi_wl_entry_slab", ubi_wl_entry_slab = kmem_cache_create("ubi_wl_entry_slab",
sizeof(struct ubi_wl_entry), sizeof(struct ubi_wl_entry),
0, 0, NULL); 0, 0, NULL);
if (!ubi_wl_entry_slab) if (!ubi_wl_entry_slab) {
err = -ENOMEM;
goto out_dev_unreg; goto out_dev_unreg;
}
err = ubi_debugfs_init(); err = ubi_debugfs_init();
if (err) if (err)