AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

9p: clear dangling pointers in p9stat_free

Browse Source 
p9stat_free is more of a cleanup function than a 'free' function as it
only frees the content of the struct; there are chances of use-after-free
if it is improperly used (e.g. p9stat_free called twice as it used to be
possible to)

Clearing dangling pointers makes the function idempotent and safer to use.

Link: http://lkml.kernel.org/r/1535410108-20650-2-git-send-email-asmadeus@codewreck.org
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Reported-by: syzbot+d4252148d198410b864f@syzkaller.appspotmail.com
This commit is contained in:
Dominique Martinet 2018-08-28 07:32:35 +09:00
parent 81c99089bc
commit 62e3941776
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/9p/protocol.c
View File

@ -46,10 +46,15 @@ p9pdu_writef(struct p9_fcall *pdu, int proto_version, const char *fmt, ...);
void p9stat_free(struct p9_wstat *stbuf) void p9stat_free(struct p9_wstat *stbuf)
{ {
kfree(stbuf->name); kfree(stbuf->name);
stbuf->name = NULL;
kfree(stbuf->uid); kfree(stbuf->uid);
stbuf->uid = NULL;
kfree(stbuf->gid); kfree(stbuf->gid);
stbuf->gid = NULL;
kfree(stbuf->muid); kfree(stbuf->muid);
stbuf->muid = NULL;
kfree(stbuf->extension); kfree(stbuf->extension);
stbuf->extension = NULL;
} }
EXPORT_SYMBOL(p9stat_free); EXPORT_SYMBOL(p9stat_free);