From 6c6199c1551b7acd4f7898f073b40ae565d3b834 Mon Sep 17 00:00:00 2001 From: Li Zefan Date: Thu, 6 Dec 2007 20:33:14 +1100 Subject: [PATCH] [POWERPC] Don't cast a struct pointer to list_head pointer The casting is safe only when the list_head member is the first member of the structure, and even then it is better to use the address of the list_head structure member. Signed-off-by: Li Zefan Signed-off-by: Paul Mackerras --- arch/ppc/syslib/ocp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ppc/syslib/ocp.c b/arch/ppc/syslib/ocp.c index 3f5be2c5ce99..d42d4085dc81 100644 --- a/arch/ppc/syslib/ocp.c +++ b/arch/ppc/syslib/ocp.c @@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int function, int index) down_write(&ocp_devices_sem); dev = __ocp_find_device(vendor, function, index); - list_del((struct list_head *)dev); + list_del(&dev->link); up_write(&ocp_devices_sem); DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: %d)... done.\n", vendor, function, index));