forked from luck/tmp_suning_uos_patched
[patch 4/5] vfs: reuse local variable in vfs_link()
Why not reuse "inode" which is assigned as struct inode *inode = old_dentry->d_inode; in the beginning of vfs_link() ? Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
This commit is contained in:
parent
2f1936b877
commit
7e79eedb3b
@ -2524,19 +2524,19 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de
|
||||
return -EPERM;
|
||||
if (!dir->i_op || !dir->i_op->link)
|
||||
return -EPERM;
|
||||
if (S_ISDIR(old_dentry->d_inode->i_mode))
|
||||
if (S_ISDIR(inode->i_mode))
|
||||
return -EPERM;
|
||||
|
||||
error = security_inode_link(old_dentry, dir, new_dentry);
|
||||
if (error)
|
||||
return error;
|
||||
|
||||
mutex_lock(&old_dentry->d_inode->i_mutex);
|
||||
mutex_lock(&inode->i_mutex);
|
||||
DQUOT_INIT(dir);
|
||||
error = dir->i_op->link(old_dentry, dir, new_dentry);
|
||||
mutex_unlock(&old_dentry->d_inode->i_mutex);
|
||||
mutex_unlock(&inode->i_mutex);
|
||||
if (!error)
|
||||
fsnotify_link(dir, old_dentry->d_inode, new_dentry);
|
||||
fsnotify_link(dir, inode, new_dentry);
|
||||
return error;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user