forked from luck/tmp_suning_uos_patched
watchdog: constify watchdog_ops structures
Check for watchdog_ops structures that are only stored in the ops field of a watchdog_device structure. This field is declared const, so watchdog_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct watchdog_ops i@p = { ... }; @ok@ identifier r.i; struct watchdog_device e; position p; @@ e.ops = &i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct watchdog_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct watchdog_ops i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
This commit is contained in:
parent
7123f253f0
commit
85f15cfc21
|
@ -107,7 +107,7 @@ static struct watchdog_info bcm7038_wdt_info = {
|
|||
WDIOF_MAGICCLOSE
|
||||
};
|
||||
|
||||
static struct watchdog_ops bcm7038_wdt_ops = {
|
||||
static const struct watchdog_ops bcm7038_wdt_ops = {
|
||||
.owner = THIS_MODULE,
|
||||
.start = bcm7038_wdt_start,
|
||||
.stop = bcm7038_wdt_stop,
|
||||
|
|
|
@ -269,7 +269,7 @@ static struct watchdog_info cdns_wdt_info = {
|
|||
};
|
||||
|
||||
/* Watchdog Core Ops */
|
||||
static struct watchdog_ops cdns_wdt_ops = {
|
||||
static const struct watchdog_ops cdns_wdt_ops = {
|
||||
.owner = THIS_MODULE,
|
||||
.start = cdns_wdt_start,
|
||||
.stop = cdns_wdt_stop,
|
||||
|
|
|
@ -430,7 +430,7 @@ static struct watchdog_info kempld_wdt_info = {
|
|||
WDIOF_PRETIMEOUT
|
||||
};
|
||||
|
||||
static struct watchdog_ops kempld_wdt_ops = {
|
||||
static const struct watchdog_ops kempld_wdt_ops = {
|
||||
.owner = THIS_MODULE,
|
||||
.start = kempld_wdt_start,
|
||||
.stop = kempld_wdt_stop,
|
||||
|
|
|
@ -136,7 +136,7 @@ static struct watchdog_info rn5t618_wdt_info = {
|
|||
.identity = DRIVER_NAME,
|
||||
};
|
||||
|
||||
static struct watchdog_ops rn5t618_wdt_ops = {
|
||||
static const struct watchdog_ops rn5t618_wdt_ops = {
|
||||
.owner = THIS_MODULE,
|
||||
.start = rn5t618_wdt_start,
|
||||
.stop = rn5t618_wdt_stop,
|
||||
|
|
|
@ -92,7 +92,7 @@ static struct watchdog_info softdog_info = {
|
|||
.options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE,
|
||||
};
|
||||
|
||||
static struct watchdog_ops softdog_ops = {
|
||||
static const struct watchdog_ops softdog_ops = {
|
||||
.owner = THIS_MODULE,
|
||||
.start = softdog_ping,
|
||||
.stop = softdog_stop,
|
||||
|
|
|
@ -302,7 +302,7 @@ static struct watchdog_info wdt_info = {
|
|||
.identity = "W83627HF Watchdog",
|
||||
};
|
||||
|
||||
static struct watchdog_ops wdt_ops = {
|
||||
static const struct watchdog_ops wdt_ops = {
|
||||
.owner = THIS_MODULE,
|
||||
.start = wdt_start,
|
||||
.stop = wdt_stop,
|
||||
|
|
Loading…
Reference in New Issue
Block a user