forked from luck/tmp_suning_uos_patched
sysfs: don't call notify_change
sysfs_chmod_file() calls notify_change() to change the permission bits on a sysfs file. Replace with explicit call to sysfs_setattr() and fsnotify_change(). This is equivalent, except that security_inode_setattr() is not called. This function is called by drivers, so the security checks do not make any sense. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
838ea8e8db
commit
93265d13ea
|
@ -14,6 +14,7 @@
|
|||
#include <linux/kobject.h>
|
||||
#include <linux/kallsyms.h>
|
||||
#include <linux/slab.h>
|
||||
#include <linux/fsnotify.h>
|
||||
#include <linux/namei.h>
|
||||
#include <linux/poll.h>
|
||||
#include <linux/list.h>
|
||||
|
@ -585,9 +586,11 @@ int sysfs_chmod_file(struct kobject *kobj, struct attribute *attr, mode_t mode)
|
|||
|
||||
newattrs.ia_mode = (mode & S_IALLUGO) | (inode->i_mode & ~S_IALLUGO);
|
||||
newattrs.ia_valid = ATTR_MODE | ATTR_CTIME;
|
||||
rc = notify_change(victim, &newattrs);
|
||||
newattrs.ia_ctime = current_fs_time(inode->i_sb);
|
||||
rc = sysfs_setattr(victim, &newattrs);
|
||||
|
||||
if (rc == 0) {
|
||||
fsnotify_change(victim, newattrs.ia_valid);
|
||||
mutex_lock(&sysfs_mutex);
|
||||
victim_sd->s_mode = newattrs.ia_mode;
|
||||
mutex_unlock(&sysfs_mutex);
|
||||
|
|
Loading…
Reference in New Issue
Block a user