AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

[SCSI] qla2xxx: remove eh_active checks in qla2xxx error handling

Browse Source 
Here's a patch which drops the eh_active checks in the qla2xxx
eh_handler callbacks.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
This commit is contained in:
Andrew Vasquez 2005-09-20 13:25:53 -07:00 committed by James Bottomley
parent 7a691bd341
commit 9a41a62b74
1 changed files with 15 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
drivers/scsi/qla2xxx/qla_os.c
View File

@ -762,29 +762,19 @@ qla2xxx_eh_device_reset(struct scsi_cmnd *cmd)
goto eh_dev_reset_done; goto eh_dev_reset_done;
} }
/* /* Flush outstanding commands. */
* If we are coming down the EH path, wait for all commands to if (qla2x00_eh_wait_for_pending_target_commands(ha, id))
* complete for the device. ret = FAILED;
*/ if (ret == FAILED) {
if (cmd->device->host->eh_active) { DEBUG3(printk("%s(%ld): failed while waiting for commands\n",
if (qla2x00_eh_wait_for_pending_target_commands(ha, id)) __func__, ha->host_no));
ret = FAILED; qla_printk(KERN_INFO, ha,
"%s: failed while waiting for commands\n", __func__);
} else
qla_printk(KERN_INFO, ha,
"scsi(%ld:%d:%d): DEVICE RESET SUCCEEDED.\n", ha->host_no,
id, lun);
if (ret == FAILED) {
DEBUG3(printk("%s(%ld): failed while waiting for "
"commands\n", __func__, ha->host_no));
qla_printk(KERN_INFO, ha,
"%s: failed while waiting for commands\n",
__func__);
goto eh_dev_reset_done;
}
}
qla_printk(KERN_INFO, ha,
"scsi(%ld:%d:%d): DEVICE RESET SUCCEEDED.\n", ha->host_no, id, lun);
eh_dev_reset_done:
return ret; return ret;
} }
@ -886,10 +876,9 @@ qla2xxx_eh_bus_reset(struct scsi_cmnd *cmd)
if (ret == FAILED) if (ret == FAILED)
goto eh_bus_reset_done; goto eh_bus_reset_done;
/* Waiting for our command in done_queue to be returned to OS.*/ /* Flush outstanding commands. */
if (cmd->device->host->eh_active) if (!qla2x00_eh_wait_for_pending_commands(ha))
if (!qla2x00_eh_wait_for_pending_commands(ha)) ret = FAILED;
ret = FAILED;
eh_bus_reset_done: eh_bus_reset_done:
qla_printk(KERN_INFO, ha, "%s: reset %s\n", __func__, qla_printk(KERN_INFO, ha, "%s: reset %s\n", __func__,