forked from luck/tmp_suning_uos_patched
rtc: cmos: clean up cmos_nvram_read()/cmos_nvram_write()
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
This commit is contained in:
parent
3c217e51d8
commit
a3781639e1
|
@ -467,13 +467,6 @@ cmos_nvram_read(struct file *filp, struct kobject *kobj,
|
|||
{
|
||||
int retval;
|
||||
|
||||
if (unlikely(off >= attr->size))
|
||||
return 0;
|
||||
if (unlikely(off < 0))
|
||||
return -EINVAL;
|
||||
if ((off + count) > attr->size)
|
||||
count = attr->size - off;
|
||||
|
||||
off += NVRAM_OFFSET;
|
||||
spin_lock_irq(&rtc_lock);
|
||||
for (retval = 0; count; count--, off++, retval++) {
|
||||
|
@ -498,12 +491,6 @@ cmos_nvram_write(struct file *filp, struct kobject *kobj,
|
|||
int retval;
|
||||
|
||||
cmos = dev_get_drvdata(container_of(kobj, struct device, kobj));
|
||||
if (unlikely(off >= attr->size))
|
||||
return -EFBIG;
|
||||
if (unlikely(off < 0))
|
||||
return -EINVAL;
|
||||
if ((off + count) > attr->size)
|
||||
count = attr->size - off;
|
||||
|
||||
/* NOTE: on at least PCs and Ataris, the boot firmware uses a
|
||||
* checksum on part of the NVRAM data. That's currently ignored
|
||||
|
|
Loading…
Reference in New Issue
Block a user