forked from luck/tmp_suning_uos_patched
[PATCH] drivers/net: remove superfluous memset
This patch covers something like this: dev = alloc_*dev(... ... priv = netdev_priv(dev); memset(priv, 0, sizeof(*priv)); The memset() here is superfluous. alloc_netdev() uses kzalloc() to allocate needed memory so there is no need to zero the priv region twice. Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Jeff Garzik <jeff@garzik.org> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
bf1e9a080d
commit
acb2cc8b20
@ -956,7 +956,6 @@ static struct net_device *fs_init_instance(struct device *dev,
|
||||
SET_MODULE_OWNER(ndev);
|
||||
|
||||
fep = netdev_priv(ndev);
|
||||
memset(fep, 0, privsize); /* clear everything */
|
||||
|
||||
fep->dev = dev;
|
||||
dev_set_drvdata(dev, ndev);
|
||||
|
@ -2956,7 +2956,6 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
|
||||
SET_NETDEV_DEV(netdev, &pdev->dev);
|
||||
|
||||
mgp = netdev_priv(netdev);
|
||||
memset(mgp, 0, sizeof(*mgp));
|
||||
mgp->dev = netdev;
|
||||
netif_napi_add(netdev, &mgp->napi,
|
||||
myri10ge_poll, myri10ge_napi_weight);
|
||||
|
@ -329,7 +329,6 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
|
||||
SET_NETDEV_DEV(netdev, &pdev->dev);
|
||||
|
||||
adapter = netdev->priv;
|
||||
memset(adapter, 0 , sizeof(struct netxen_adapter));
|
||||
|
||||
adapter->ahw.pdev = pdev;
|
||||
adapter->ahw.pci_func = pci_func_id;
|
||||
|
@ -1335,7 +1335,6 @@ static int __devinit sparc_lance_probe_one(struct sbus_dev *sdev,
|
||||
return -ENOMEM;
|
||||
|
||||
lp = netdev_priv(dev);
|
||||
memset(lp, 0, sizeof(*lp));
|
||||
|
||||
if (sparc_lance_debug && version_printed++ == 0)
|
||||
printk (KERN_INFO "%s", version);
|
||||
|
@ -1306,7 +1306,6 @@ static int pegasus_probe(struct usb_interface *intf,
|
||||
}
|
||||
|
||||
pegasus = netdev_priv(net);
|
||||
memset(pegasus, 0, sizeof (struct pegasus));
|
||||
pegasus->dev_index = dev_index;
|
||||
init_waitqueue_head(&pegasus->ctrl_wait);
|
||||
|
||||
|
@ -905,7 +905,6 @@ static int rtl8150_probe(struct usb_interface *intf,
|
||||
}
|
||||
|
||||
dev = netdev_priv(netdev);
|
||||
memset(dev, 0, sizeof(rtl8150_t));
|
||||
|
||||
dev->intr_buff = kmalloc(INTBUFSIZE, GFP_KERNEL);
|
||||
if (!dev->intr_buff) {
|
||||
|
Loading…
Reference in New Issue
Block a user