ath5k: simplify passed params to ath5k_hw_set_associd()

We have access to common->curbssid and common->curaid so just
use those. Note that common->curaid is always 0 so this keeps
our current behaviour of always using 0 for now. Once we fix
storing the association ID passed by mac80211 this will
require no changes here.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Luis R. Rodriguez 2009-10-06 20:44:31 -04:00 committed by John W. Linville
parent 91b9eb8261
commit be5d6b75e0
5 changed files with 9 additions and 9 deletions

View File

@ -1191,7 +1191,7 @@ extern bool ath5k_eeprom_is_hb63(struct ath5k_hw *ah);
extern int ath5k_hw_set_opmode(struct ath5k_hw *ah); extern int ath5k_hw_set_opmode(struct ath5k_hw *ah);
/* BSSID Functions */ /* BSSID Functions */
extern int ath5k_hw_set_lladdr(struct ath5k_hw *ah, const u8 *mac); extern int ath5k_hw_set_lladdr(struct ath5k_hw *ah, const u8 *mac);
extern void ath5k_hw_set_associd(struct ath5k_hw *ah, const u8 *bssid, u16 assoc_id); extern void ath5k_hw_set_associd(struct ath5k_hw *ah);
extern void ath5k_hw_set_bssid_mask(struct ath5k_hw *ah, const u8 *mask); extern void ath5k_hw_set_bssid_mask(struct ath5k_hw *ah, const u8 *mask);
/* Receive start/stop functions */ /* Receive start/stop functions */
extern void ath5k_hw_start_rx_pcu(struct ath5k_hw *ah); extern void ath5k_hw_start_rx_pcu(struct ath5k_hw *ah);

View File

@ -326,7 +326,7 @@ int ath5k_hw_attach(struct ath5k_softc *sc)
/* Set BSSID to bcast address: ff:ff:ff:ff:ff:ff for now */ /* Set BSSID to bcast address: ff:ff:ff:ff:ff:ff for now */
memcpy(common->curbssid, ath_bcast_mac, ETH_ALEN); memcpy(common->curbssid, ath_bcast_mac, ETH_ALEN);
ath5k_hw_set_associd(ah, common->curbssid, 0); ath5k_hw_set_associd(ah);
ath5k_hw_set_opmode(ah); ath5k_hw_set_opmode(ah);
ath5k_hw_rfgain_opt_init(ah); ath5k_hw_rfgain_opt_init(ah);

View File

@ -3213,7 +3213,7 @@ static void ath5k_bss_info_changed(struct ieee80211_hw *hw,
memcpy(common->curbssid, bss_conf->bssid, ETH_ALEN); memcpy(common->curbssid, bss_conf->bssid, ETH_ALEN);
/* XXX: assoc id is set to 0 for now, mac80211 doesn't have /* XXX: assoc id is set to 0 for now, mac80211 doesn't have
* a clean way of letting us retrieve this yet. */ * a clean way of letting us retrieve this yet. */
ath5k_hw_set_associd(ah, common->curbssid, 0); ath5k_hw_set_associd(ah);
mmiowb(); mmiowb();
} }

View File

@ -279,7 +279,7 @@ int ath5k_hw_set_lladdr(struct ath5k_hw *ah, const u8 *mac)
* *
* Sets the BSSID which trigers the "SME Join" operation * Sets the BSSID which trigers the "SME Join" operation
*/ */
void ath5k_hw_set_associd(struct ath5k_hw *ah, const u8 *bssid, u16 assoc_id) void ath5k_hw_set_associd(struct ath5k_hw *ah)
{ {
struct ath_common *common = ath5k_hw_common(ah); struct ath_common *common = ath5k_hw_common(ah);
u32 low_id, high_id; u32 low_id, high_id;
@ -294,13 +294,13 @@ void ath5k_hw_set_associd(struct ath5k_hw *ah, const u8 *bssid, u16 assoc_id)
/* /*
* Set BSSID which triggers the "SME Join" operation * Set BSSID which triggers the "SME Join" operation
*/ */
low_id = get_unaligned_le32(bssid); low_id = get_unaligned_le32(common->curbssid);
high_id = get_unaligned_le16(bssid + 4); high_id = get_unaligned_le16(common->curbssid + 4);
ath5k_hw_reg_write(ah, low_id, AR_BSSMSKL); ath5k_hw_reg_write(ah, low_id, AR_BSSMSKL);
ath5k_hw_reg_write(ah, high_id | ((assoc_id & 0x3fff) << ath5k_hw_reg_write(ah, high_id | ((common->curaid & 0x3fff) <<
AR5K_BSS_ID1_AID_S), AR_BSSMSKU); AR5K_BSS_ID1_AID_S), AR_BSSMSKU);
if (assoc_id == 0) { if (common->curaid == 0) {
ath5k_hw_disable_pspoll(ah); ath5k_hw_disable_pspoll(ah);
return; return;
} }

View File

@ -1188,7 +1188,7 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum nl80211_iftype op_mode,
/* Restore bssid and bssid mask */ /* Restore bssid and bssid mask */
/* XXX: add ah->aid once mac80211 gives this to us */ /* XXX: add ah->aid once mac80211 gives this to us */
ath5k_hw_set_associd(ah, common->curbssid, 0); ath5k_hw_set_associd(ah);
/* Set PCU config */ /* Set PCU config */
ath5k_hw_set_opmode(ah); ath5k_hw_set_opmode(ah);