forked from luck/tmp_suning_uos_patched
checkpatch: improve seq_print->seq_puts suggestion
Improve the format specifier test by removing any %% before looking for any remaining % format specifier. Signed-off-by: Heba Aamer <heba93aamer@gmail.com> Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
f8e58219dc
commit
caac1d5fdd
|
@ -4854,7 +4854,8 @@ sub process {
|
|||
# check for seq_printf uses that could be seq_puts
|
||||
if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) {
|
||||
my $fmt = get_quoted_string($line, $rawline);
|
||||
if ($fmt ne "" && $fmt !~ /[^\\]\%/) {
|
||||
$fmt =~ s/%%//g;
|
||||
if ($fmt !~ /%/) {
|
||||
if (WARN("PREFER_SEQ_PUTS",
|
||||
"Prefer seq_puts to seq_printf\n" . $herecurr) &&
|
||||
$fix) {
|
||||
|
|
Loading…
Reference in New Issue
Block a user