forked from luck/tmp_suning_uos_patched
[PATCH] dm kcopyd: error accumulation fix
kcopyd should accumulate errors - otherwise I/O failures may be ignored unintentionally. And invert 'success' (used in a future patch), using a more intuitive !(read_err || write_err). Signed-off-by: Jonathan Brassow <jbrassow@redhat.com> Signed-off-by: Alasdair G Kergon <agk@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
8a835f11bc
commit
ce503f59ae
|
@ -602,7 +602,7 @@ static void recovery_complete(int read_err, unsigned int write_err,
|
|||
struct region *reg = (struct region *) context;
|
||||
|
||||
/* FIXME: better error handling */
|
||||
rh_recovery_end(reg, read_err || write_err);
|
||||
rh_recovery_end(reg, !(read_err || write_err));
|
||||
}
|
||||
|
||||
static int recover(struct mirror_set *ms, struct region *reg)
|
||||
|
|
|
@ -314,7 +314,7 @@ static void complete_io(unsigned long error, void *context)
|
|||
|
||||
if (error) {
|
||||
if (job->rw == WRITE)
|
||||
job->write_err &= error;
|
||||
job->write_err |= error;
|
||||
else
|
||||
job->read_err = 1;
|
||||
|
||||
|
@ -460,7 +460,7 @@ static void segment_complete(int read_err,
|
|||
job->read_err = 1;
|
||||
|
||||
if (write_err)
|
||||
job->write_err &= write_err;
|
||||
job->write_err |= write_err;
|
||||
|
||||
/*
|
||||
* Only dispatch more work if there hasn't been an error.
|
||||
|
|
Loading…
Reference in New Issue
Block a user