AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

ALSA: firewire-lib: Fix 'amdtp_domain_start()' when no AMDTP_OUT_STREAM stream is found

Browse Source 
[ Upstream commit 0cbbeaf370221fc469c95945dd3c1198865c5fe4 ]

The intent here is to return an error code if we don't find what we are
looking for in the 'list_for_each_entry()' loop.

's' is not NULL if the list is empty or if we scan the complete list.
Introduce a new 'found' variable to handle such cases.

Fixes: 60dd49298e ("ALSA: firewire-lib: handle several AMDTP streams in callback handler of IRQ target")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/9c9a53a4905984a570ba5672cbab84f2027dedc1.1624560484.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Christophe JAILLET 2021-06-24 20:49:36 +02:00 committed by Greg Kroah-Hartman
parent 53fa3ba808
commit dd6d4e92e7
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sound/firewire/amdtp-stream.c
View File

@ -1404,14 +1404,17 @@ int amdtp_domain_start(struct amdtp_domain *d, unsigned int ir_delay_cycle)
unsigned int queue_size; unsigned int queue_size;
struct amdtp_stream *s; struct amdtp_stream *s;
int cycle; int cycle;
bool found = false;
int err; int err;
// Select an IT context as IRQ target. // Select an IT context as IRQ target.
list_for_each_entry(s, &d->streams, list) { list_for_each_entry(s, &d->streams, list) {
if (s->direction == AMDTP_OUT_STREAM) if (s->direction == AMDTP_OUT_STREAM) {
found = true;
break; break;
}
} }
if (!s) if (!found)
return -ENXIO; return -ENXIO;
d->irq_target = s; d->irq_target = s;