forked from luck/tmp_suning_uos_patched
xfs: only allocate the buffer size actually needed in __xfs_set_acl
No need to allocate the max size if we can just allocate the easily known actual ACL size. Suggested-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:
parent
f311d771a0
commit
ed02d13f5d
|
@ -191,16 +191,11 @@ __xfs_set_acl(struct inode *inode, struct posix_acl *acl, int type)
|
|||
args.namelen = strlen(args.name);
|
||||
|
||||
if (acl) {
|
||||
args.valuelen = XFS_ACL_MAX_SIZE(ip->i_mount);
|
||||
args.valuelen = XFS_ACL_SIZE(acl->a_count);
|
||||
args.value = kmem_zalloc_large(args.valuelen, 0);
|
||||
if (!args.value)
|
||||
return -ENOMEM;
|
||||
|
||||
xfs_acl_to_disk(args.value, acl);
|
||||
|
||||
/* subtract away the unused acl entries */
|
||||
args.valuelen -= sizeof(struct xfs_acl_entry) *
|
||||
(XFS_ACL_MAX_ENTRIES(ip->i_mount) - acl->a_count);
|
||||
}
|
||||
|
||||
error = xfs_attr_set(&args);
|
||||
|
|
Loading…
Reference in New Issue
Block a user