forked from luck/tmp_suning_uos_patched
netxen: do_rom_fast_write error handling
Compiler warning spots real error! The function do_rom_fast_read called in do_rom_fast_write can fail and leave data1 unset. This causes a compile warning. The correct thing is to propagate the error out. Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
parent
36c843d5e3
commit
f8dfdd5cab
|
@ -499,7 +499,10 @@ static inline int do_rom_fast_write_words(struct netxen_adapter *adapter,
|
|||
while(1) {
|
||||
int data1;
|
||||
|
||||
do_rom_fast_read(adapter, addridx, &data1);
|
||||
ret = do_rom_fast_read(adapter, addridx, &data1);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
|
||||
if (data1 == data)
|
||||
break;
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user