AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

nvmet-tcp: fix uninitialized variable access

Browse Source 
If we end up in nvmet_tcp_try_recv_one with a bogus state
queue receive state we will access result which is uninitialized.

Initialize restult to 0 which will be considered as if no data
was received by the tcp socket.

Fixes: 872d26a391 ("nvmet-tcp: add NVMe over TCP target driver")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Sagi Grimberg 2019-01-09 14:56:32 -08:00 committed by Jens Axboe
parent 7809167da5
commit fb8658581a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/nvme/target/tcp.c
View File

@ -1089,7 +1089,7 @@ static int nvmet_tcp_try_recv_ddgst(struct nvmet_tcp_queue *queue)
static int nvmet_tcp_try_recv_one(struct nvmet_tcp_queue *queue) static int nvmet_tcp_try_recv_one(struct nvmet_tcp_queue *queue)
{ {
int result; int result = 0;
if (unlikely(queue->rcv_state == NVMET_TCP_RECV_ERR)) if (unlikely(queue->rcv_state == NVMET_TCP_RECV_ERR))
return 0; return 0;