AcoSail/kernel_optimize_test
8
0
Fork 0
forked from luck/tmp_suning_uos_patched
Code Pull Requests Activity

net: microchip: encx24j600: add missed kthread_stop

Browse Source 
This driver calls kthread_run() in probe, but forgets to call
kthread_stop() in probe failure and remove.
Add the missed kthread_stop() to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Chuhong Yuan 2020-05-07 23:13:20 +08:00 committed by David S. Miller
parent 09454fd0a4
commit ff8ce319e9
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/microchip/encx24j600.c
View File

@ -1070,7 +1070,7 @@ static int encx24j600_spi_probe(struct spi_device *spi)
if (unlikely(ret)) { if (unlikely(ret)) {
netif_err(priv, probe, ndev, "Error %d initializing card encx24j600 card\n", netif_err(priv, probe, ndev, "Error %d initializing card encx24j600 card\n",
ret); ret);
goto out_free; goto out_stop;
} }
eidled = encx24j600_read_reg(priv, EIDLED); eidled = encx24j600_read_reg(priv, EIDLED);
@ -1088,6 +1088,8 @@ static int encx24j600_spi_probe(struct spi_device *spi)
out_unregister: out_unregister:
unregister_netdev(priv->ndev); unregister_netdev(priv->ndev);
out_stop:
kthread_stop(priv->kworker_task);
out_free: out_free:
free_netdev(ndev); free_netdev(ndev);
@ -1100,6 +1102,7 @@ static int encx24j600_spi_remove(struct spi_device *spi)
struct encx24j600_priv *priv = dev_get_drvdata(&spi->dev); struct encx24j600_priv *priv = dev_get_drvdata(&spi->dev);
unregister_netdev(priv->ndev); unregister_netdev(priv->ndev);
kthread_stop(priv->kworker_task);
free_netdev(priv->ndev); free_netdev(priv->ndev);