forked from luck/tmp_suning_uos_patched
311633b604
Switching from ->priv_destructor to dellink() has an unexpected consequence: existing RCU readers, that is, hsr_port_get_hsr() callers, may still be able to read the port list. Instead of checking the return value of each hsr_port_get_hsr(), we can just move it to ->ndo_uninit() which is called after device unregister and synchronize_net(), and we still have RTNL lock there. Fixes:b9a1e62740("hsr: implement dellink to clean up resources") Fixes:edf070a0fb("hsr: fix a NULL pointer deref in hsr_dev_xmit()") Reported-by: syzbot+097ef84cdc95843fbaa8@syzkaller.appspotmail.com Cc: Arvid Brodin <arvid.brodin@alten.se> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
22 lines
620 B
C
22 lines
620 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright 2011-2014 Autronica Fire and Security AS
|
|
*
|
|
* Author(s):
|
|
* 2011-2014 Arvid Brodin, arvid.brodin@alten.se
|
|
*/
|
|
|
|
#ifndef __HSR_DEVICE_H
|
|
#define __HSR_DEVICE_H
|
|
|
|
#include <linux/netdevice.h>
|
|
#include "hsr_main.h"
|
|
|
|
void hsr_dev_setup(struct net_device *dev);
|
|
int hsr_dev_finalize(struct net_device *hsr_dev, struct net_device *slave[2],
|
|
unsigned char multicast_spec, u8 protocol_version);
|
|
void hsr_check_carrier_and_operstate(struct hsr_priv *hsr);
|
|
bool is_hsr_master(struct net_device *dev);
|
|
int hsr_get_max_mtu(struct hsr_priv *hsr);
|
|
|
|
#endif /* __HSR_DEVICE_H */
|