forked from luck/tmp_suning_uos_patched
256a804283
I was observing the following error messages on my OMAP1 based Amstrad Delta board when first changing from text to graphics mode or vice versa after the LCD display had been blanked: omapfb omapfb: timeout waiting for FRAME DONE with a followup error message while unblanking it back: omapfb omapfb: resetting (status 0xffffffb2,reset count 1) As a visible result, image pixels happened to be shifted by a few bits, giving wrong colors. Examining the code, I found that this problem occures when an OMAP1 internal LCD controller is disabled from omap_lcdc_suspend() and then a subsequent omap_lcdc_setup_plane() calls disable_controller() again. This potentially error provoking behaviour is triggered by the lcdc.update_mode flag being kept at OMAP_AUTO_UPDATE, regardless of the controller and panel being suspended. This patch tries to correct the problem by replacing both omap_lcdc_suspend() and omap_lcdc_resume() function bodies with single calls to omap_lcdc_set_update_mode() with a respective OMAP_UPDATE_DISABLE or OMAP_AUTO_UPDATE argument. As a result, exactly the same lower level operations are performed, with addition of changing the lcdc.update_mode flag to a value better suited for the controller state. This prevents any further calls to disable_controller() from omap_lcdc_setup_plane() while the display is suspended. Created against linux-2.6.34-rc7. Tested on Amstrad Delta. Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com> |
||
|---|---|---|
| .. | ||
| blizzard.c | ||
| dispc.c | ||
| dispc.h | ||
| hwa742.c | ||
| Kconfig | ||
| lcd_2430sdp.c | ||
| lcd_ams_delta.c | ||
| lcd_apollon.c | ||
| lcd_h3.c | ||
| lcd_h4.c | ||
| lcd_htcherald.c | ||
| lcd_inn1510.c | ||
| lcd_inn1610.c | ||
| lcd_ldp.c | ||
| lcd_mipid.c | ||
| lcd_omap2evm.c | ||
| lcd_omap3beagle.c | ||
| lcd_omap3evm.c | ||
| lcd_osk.c | ||
| lcd_overo.c | ||
| lcd_palmte.c | ||
| lcd_palmtt.c | ||
| lcd_palmz71.c | ||
| lcdc.c | ||
| lcdc.h | ||
| Makefile | ||
| omapfb_main.c | ||
| omapfb.h | ||
| rfbi.c | ||
| sossi.c | ||