Jason Yan 2fa4a32613 scsi: libsas: dynamically allocate and free ata host ... Commit 2623c7a5f2 ("libata: add refcounting to ata_host") v4.17+ introduced refcounting to ata_host and will increase or decrease the refcount when adding or deleting transport ATA port. Now the ata host for libsas is embedded in domain_device, and the ->kref member is not initialized. Afer we add ata transport class, ata_host_get() will be called when adding transport ATA port and a warning will be triggered as below: refcount_t: increment on 0; use-after-free. WARNING: CPU: 2 PID: 103 at lib/refcount.c:153 refcount_inc+0x40/0x48 ...... Call trace: refcount_inc+0x40/0x48 ata_host_get+0x10/0x18 ata_tport_add+0x40/0x120 ata_sas_tport_add+0xc/0x14 sas_ata_init+0x7c/0xc8 sas_discover_domain+0x380/0x53c process_one_work+0x12c/0x288 worker_thread+0x58/0x3f0 kthread+0xfc/0x128 ret_from_fork+0x10/0x18 And also when removing transport ATA port ata_host_put() will be called and another similar warning will be triggered. If the refcount decreased to zero, the ata host will be freed. But this ata host is only part of domain_device, it cannot be freed directly. So we have to change this embedded static ata host to a dynamically allocated ata host and initialize the ->kref member. To use ata_host_get() and ata_host_put() in libsas, we need to move the declaration of these functions to the public libata.h and export them. Fixes: b6240a4df0 ("scsi: libsas: add transport class for ATA devices") Signed-off-by: Jason Yan <yanaijie@huawei.com> CC: John Garry <john.garry@huawei.com> CC: Taras Kondratiuk <takondra@cisco.com> CC: Tejun Heo <tj@kernel.org> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2018-06-19 22:02:25 -04:00
..
fc
fc_encode.h
fc_frame.h
fcoe_sysfs.h
iscsi_if.h
iscsi_proto.h
iser.h
libfc.h
libfcoe.h
libiscsi_tcp.h
libiscsi.h
libsas.h	scsi: libsas: dynamically allocate and free ata host	2018-06-19 22:02:25 -04:00
osd_attributes.h
osd_initiator.h	scsi/osd: remove the gfp argument to osd_start_request	2018-05-14 08:55:09 -06:00
osd_ore.h
osd_protocol.h
osd_sec.h
osd_sense.h
osd_types.h
sas_ata.h
sas.h
scsi_bsg_iscsi.h
scsi_cmnd.h	Merge branch 'fixes' into misc	2018-04-03 17:38:39 -07:00
scsi_common.h
scsi_dbg.h	scsi: core: remove reference to scsi_show_extd_sense()	2018-04-18 23:37:39 -04:00
scsi_device.h	scsi: devinfo: change blist_flag_t to 64bit	2018-04-20 19:14:35 -04:00
scsi_devinfo.h	scsi: devinfo: BLIST_RETRY_ASC_C1 for Fujitsu ETERNUS	2018-04-20 19:14:36 -04:00
scsi_dh.h
scsi_driver.h
scsi_eh.h
scsi_host.h	block: rename BLK_EH_NOT_HANDLED to BLK_EH_DONE	2018-05-29 08:59:21 -06:00
scsi_ioctl.h
scsi_proto.h
scsi_request.h
scsi_tcq.h
scsi_transport_fc.h
scsi_transport_iscsi.h
scsi_transport_sas.h
scsi_transport_spi.h
scsi_transport_srp.h
scsi_transport.h
scsi.h
scsicam.h
sg.h
srp.h
viosrp.h