forked from luck/tmp_suning_uos_patched
a2c17c93b7
[ Upstream commit 9f0b3e0cc0c88618aa9e5cecef747b1337ae0a5d ] Up until commitea7e586bdd("iio: st_sensors: move regulator retrieveal to core") only the ST pressure driver seems to have had any regulator disable. After that commit, the regulator handling was moved into the common st_sensors logic. In all instances of this regulator handling, the regulators were disabled before unregistering the IIO device. This can cause issues where the device would be powered down and still be available to userspace, allowing it to send invalid/garbage data. This change moves the st_sensors_power_disable() after the common probe functions. These common probe functions also handle unregistering the IIO device. Fixes:774487611c("iio: pressure-core: st: Provide support for the Vdd power supply") Fixes:ea7e586bdd("iio: st_sensors: move regulator retrieveal to core") Cc: Lee Jones <lee.jones@linaro.org> Cc: Denis CIOCCA <denis.ciocca@st.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com> Link: https://lore.kernel.org/r/20210823112204.243255-2-aardelean@deviqon.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
143 lines
3.2 KiB
C
143 lines
3.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* STMicroelectronics pressures driver
|
|
*
|
|
* Copyright 2013 STMicroelectronics Inc.
|
|
*
|
|
* Denis Ciocca <denis.ciocca@st.com>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/iio/iio.h>
|
|
|
|
#include <linux/iio/common/st_sensors.h>
|
|
#include <linux/iio/common/st_sensors_i2c.h>
|
|
#include "st_pressure.h"
|
|
|
|
static const struct of_device_id st_press_of_match[] = {
|
|
{
|
|
.compatible = "st,lps001wp-press",
|
|
.data = LPS001WP_PRESS_DEV_NAME,
|
|
},
|
|
{
|
|
.compatible = "st,lps25h-press",
|
|
.data = LPS25H_PRESS_DEV_NAME,
|
|
},
|
|
{
|
|
.compatible = "st,lps331ap-press",
|
|
.data = LPS331AP_PRESS_DEV_NAME,
|
|
},
|
|
{
|
|
.compatible = "st,lps22hb-press",
|
|
.data = LPS22HB_PRESS_DEV_NAME,
|
|
},
|
|
{
|
|
.compatible = "st,lps33hw",
|
|
.data = LPS33HW_PRESS_DEV_NAME,
|
|
},
|
|
{
|
|
.compatible = "st,lps35hw",
|
|
.data = LPS35HW_PRESS_DEV_NAME,
|
|
},
|
|
{
|
|
.compatible = "st,lps22hh",
|
|
.data = LPS22HH_PRESS_DEV_NAME,
|
|
},
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, st_press_of_match);
|
|
|
|
#ifdef CONFIG_ACPI
|
|
static const struct acpi_device_id st_press_acpi_match[] = {
|
|
{"SNO9210", LPS22HB},
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, st_press_acpi_match);
|
|
#endif
|
|
|
|
static const struct i2c_device_id st_press_id_table[] = {
|
|
{ LPS001WP_PRESS_DEV_NAME, LPS001WP },
|
|
{ LPS25H_PRESS_DEV_NAME, LPS25H },
|
|
{ LPS331AP_PRESS_DEV_NAME, LPS331AP },
|
|
{ LPS22HB_PRESS_DEV_NAME, LPS22HB },
|
|
{ LPS33HW_PRESS_DEV_NAME, LPS33HW },
|
|
{ LPS35HW_PRESS_DEV_NAME, LPS35HW },
|
|
{ LPS22HH_PRESS_DEV_NAME, LPS22HH },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, st_press_id_table);
|
|
|
|
static int st_press_i2c_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
const struct st_sensor_settings *settings;
|
|
struct st_sensor_data *press_data;
|
|
struct iio_dev *indio_dev;
|
|
int ret;
|
|
|
|
st_sensors_dev_name_probe(&client->dev, client->name, sizeof(client->name));
|
|
|
|
settings = st_press_get_settings(client->name);
|
|
if (!settings) {
|
|
dev_err(&client->dev, "device name %s not recognized.\n",
|
|
client->name);
|
|
return -ENODEV;
|
|
}
|
|
|
|
indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*press_data));
|
|
if (!indio_dev)
|
|
return -ENOMEM;
|
|
|
|
press_data = iio_priv(indio_dev);
|
|
press_data->sensor_settings = (struct st_sensor_settings *)settings;
|
|
|
|
ret = st_sensors_i2c_configure(indio_dev, client);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = st_sensors_power_enable(indio_dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = st_press_common_probe(indio_dev);
|
|
if (ret < 0)
|
|
goto st_press_power_off;
|
|
|
|
return 0;
|
|
|
|
st_press_power_off:
|
|
st_sensors_power_disable(indio_dev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int st_press_i2c_remove(struct i2c_client *client)
|
|
{
|
|
struct iio_dev *indio_dev = i2c_get_clientdata(client);
|
|
|
|
st_press_common_remove(indio_dev);
|
|
|
|
st_sensors_power_disable(indio_dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct i2c_driver st_press_driver = {
|
|
.driver = {
|
|
.name = "st-press-i2c",
|
|
.of_match_table = st_press_of_match,
|
|
.acpi_match_table = ACPI_PTR(st_press_acpi_match),
|
|
},
|
|
.probe = st_press_i2c_probe,
|
|
.remove = st_press_i2c_remove,
|
|
.id_table = st_press_id_table,
|
|
};
|
|
module_i2c_driver(st_press_driver);
|
|
|
|
MODULE_AUTHOR("Denis Ciocca <denis.ciocca@st.com>");
|
|
MODULE_DESCRIPTION("STMicroelectronics pressures i2c driver");
|
|
MODULE_LICENSE("GPL v2");
|