Christoph Paasch 398f0132c1 net/packet: Set __GFP_NOWARN upon allocation in alloc_pg_vec ... Since commit fc62814d69 ("net/packet: fix 4gb buffer limit due to overflow check") one can now allocate packet ring buffers >= UINT_MAX. However, syzkaller found that that triggers a warning: [ 21.100000] WARNING: CPU: 2 PID: 2075 at mm/page_alloc.c:4584 __alloc_pages_nod0 [ 21.101490] Modules linked in: [ 21.101921] CPU: 2 PID: 2075 Comm: syz-executor.0 Not tainted 5.0.0 #146 [ 21.102784] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.5.1 01/01/2011 [ 21.103887] RIP: 0010:__alloc_pages_nodemask+0x2a0/0x630 [ 21.104640] Code: fe ff ff 65 48 8b 04 25 c0 de 01 00 48 05 90 0f 00 00 41 bd 01 00 00 00 48 89 44 24 48 e9 9c fe 3 [ 21.107121] RSP: 0018:ffff88805e1cf920 EFLAGS: 00010246 [ 21.107819] RAX: 0000000000000000 RBX: ffffffff85a488a0 RCX: 0000000000000000 [ 21.108753] RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 0000000000000000 [ 21.109699] RBP: 1ffff1100bc39f28 R08: ffffed100bcefb67 R09: ffffed100bcefb67 [ 21.110646] R10: 0000000000000001 R11: ffffed100bcefb66 R12: 000000000000000d [ 21.111623] R13: 0000000000000000 R14: ffff88805e77d888 R15: 000000000000000d [ 21.112552] FS: 00007f7c7de05700(0000) GS:ffff88806d100000(0000) knlGS:0000000000000000 [ 21.113612] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 21.114405] CR2: 000000000065c000 CR3: 000000005e58e006 CR4: 00000000001606e0 [ 21.115367] Call Trace: [ 21.115705] ? __alloc_pages_slowpath+0x21c0/0x21c0 [ 21.116362] alloc_pages_current+0xac/0x1e0 [ 21.116923] kmalloc_order+0x18/0x70 [ 21.117393] kmalloc_order_trace+0x18/0x110 [ 21.117949] packet_set_ring+0x9d5/0x1770 [ 21.118524] ? packet_rcv_spkt+0x440/0x440 [ 21.119094] ? lock_downgrade+0x620/0x620 [ 21.119646] ? __might_fault+0x177/0x1b0 [ 21.120177] packet_setsockopt+0x981/0x2940 [ 21.120753] ? __fget+0x2fb/0x4b0 [ 21.121209] ? packet_release+0xab0/0xab0 [ 21.121740] ? sock_has_perm+0x1cd/0x260 [ 21.122297] ? selinux_secmark_relabel_packet+0xd0/0xd0 [ 21.123013] ? __fget+0x324/0x4b0 [ 21.123451] ? selinux_netlbl_socket_setsockopt+0x101/0x320 [ 21.124186] ? selinux_netlbl_sock_rcv_skb+0x3a0/0x3a0 [ 21.124908] ? __lock_acquire+0x529/0x3200 [ 21.125453] ? selinux_socket_setsockopt+0x5d/0x70 [ 21.126075] ? __sys_setsockopt+0x131/0x210 [ 21.126533] ? packet_release+0xab0/0xab0 [ 21.127004] __sys_setsockopt+0x131/0x210 [ 21.127449] ? kernel_accept+0x2f0/0x2f0 [ 21.127911] ? ret_from_fork+0x8/0x50 [ 21.128313] ? do_raw_spin_lock+0x11b/0x280 [ 21.128800] __x64_sys_setsockopt+0xba/0x150 [ 21.129271] ? lockdep_hardirqs_on+0x37f/0x560 [ 21.129769] do_syscall_64+0x9f/0x450 [ 21.130182] entry_SYSCALL_64_after_hwframe+0x49/0xbe We should allocate with __GFP_NOWARN to handle this. Cc: Kal Conley <kal.conley@dectris.com> Cc: Andrey Konovalov <andreyknvl@google.com> Fixes: fc62814d69 ("net/packet: fix 4gb buffer limit due to overflow check") Signed-off-by: Christoph Paasch <cpaasch@apple.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-03-20 10:46:50 -07:00
..
6lowpan	6lowpan: fix debugfs_simple_attr.cocci warnings	2019-01-22 09:51:19 +01:00
9p	9p/net: put a lower bound on msize	2018-12-25 17:07:49 +09:00
802
8021q	net: Remove switchdev.h inclusion from team/bond/vlan	2019-02-24 17:40:46 -08:00
appletalk	appletalk: Fix potential NULL pointer dereference in unregister_snap_client	2019-03-15 11:25:48 -07:00
atm	net: atm: Add another IS_ENABLED(CONFIG_COMPAT) in atm_dev_ioctl	2019-03-07 10:14:50 -08:00
ax25	ax25: fix possible use-after-free	2019-01-23 11:18:00 -08:00
batman-adv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-02-15 12:38:38 -08:00
bluetooth	Bluetooth: Add quirk for reading BD_ADDR from fwnode property	2019-02-26 10:08:26 +01:00
bpf	bpf: fix warning about using plain integer as NULL	2019-03-08 21:17:07 +01:00
bpfilter	bpfilter: re-add header search paths to tools include to fix build error	2019-02-23 13:34:40 -08:00
bridge	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2019-03-02 14:01:04 -08:00
caif	net: caif: use skb helpers instead of open-coding them	2019-02-17 11:01:17 -08:00
can	can: bcm: check timer values before ktime conversion	2019-01-22 11:33:46 +01:00
ceph	libceph: use struct_size() for kmalloc() in crush_decode()	2019-03-05 18:55:17 +01:00
core	net-sysfs: call dev_hold if kobject_init_and_add success	2019-03-19 13:45:58 -07:00
dcb
dccp	dccp: do not use ipv6 header for ipv4 flow	2019-03-19 14:01:40 -07:00
decnet	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-01-29 21:18:54 -08:00
dns_resolver
dsa	net: dsa: Use prepare/commit phase in dsa_slave_vlan_rx_add_vid()	2019-03-03 20:45:52 -08:00
ethernet	net/ethernet: Add parse_protocol header_ops support	2019-02-22 12:55:31 -08:00
hsr	net/hsr: fix possible crash in add_timer()	2019-03-07 11:02:08 -08:00
ieee802154	net: remove unused struct inet_frag_queue.fragments field	2019-02-26 08:27:05 -08:00
ife
ipv4	tcp: Don't access TCP_SKB_CB before initializing it	2019-03-11 15:36:49 -07:00
ipv6	tcp: do not use ipv6 header for ipv4 flow	2019-03-19 14:00:27 -07:00
iucv
kcm	kcm: Remove unnecessary SLAB_PANIC for kmem_cache_create() in kcm_init	2019-02-23 13:46:24 -08:00
key	af_key: unconditionally clone on broadcast	2019-02-12 10:36:42 +01:00
l2tp	l2tp: fix infoleak in l2tp_ip6_recvmsg()	2019-03-13 14:19:35 -07:00
l3mdev
lapb
llc
mac80211	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-02-24 12:06:19 -08:00
mac802154
mpls	mpls: Fix 6PE forwarding	2019-03-19 16:00:22 -07:00
ncsi	net: ncsi: fix a missing check for nla_nest_start	2019-03-16 11:44:33 -07:00
netfilter	netfilter: nf_tables: return immediately on empty commit	2019-03-11 20:01:20 +01:00
netlabel	netlabel: fix out-of-bounds memory accesses	2019-02-27 21:45:24 -08:00
netlink	rhashtable: Remove obsolete rhashtable_walk_init function	2019-02-22 13:49:00 +01:00
netrom	netrom: switch to sock timer API	2019-01-27 10:38:04 -08:00
nfc	nfc: Fix to check for kmemdup failure	2019-03-19 13:48:07 -07:00
nsh
openvswitch	net: openvswitch: fix missing checks for nla_nest_start	2019-03-16 11:43:14 -07:00
packet	net/packet: Set __GFP_NOWARN upon allocation in alloc_pg_vec	2019-03-20 10:46:50 -07:00
phonet	phonet: fix building with clang	2019-02-21 16:23:56 -08:00
psample
qrtr	mm: replace all open encodings for NUMA_NO_NODE	2019-03-05 21:07:14 -08:00
rds	5.1 Merge Window Pull Request	2019-03-09 15:53:03 -08:00
rfkill	rfkill: gpio: Remove unused include	2018-12-18 13:13:56 +01:00
rose	net: rose: fix a possible stack overflow	2019-03-18 16:53:22 -07:00
rxrpc	rxrpc: Fix client call queueing, waiting for channel	2019-03-08 18:24:53 -08:00
sched	sch_cake: Interpret fwmark parameter as a bitmask	2019-03-15 11:57:14 -07:00
sctp	sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_STREAM_SCHEDULER sockopt	2019-03-18 18:31:09 -07:00
smc	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-03-12 13:27:20 -07:00
strparser	net: strparser: fix a missing check for create_singlethread_workqueue	2019-03-15 12:51:56 -07:00
sunrpc	Miscellaneous NFS server fixes. Probably the most visible bug is one	2019-03-12 15:06:54 -07:00
switchdev	switchdev: Remove unused transaction item queue	2019-03-01 21:35:19 -08:00
tipc	tipc: allow service ranges to be connect()'ed on RDM/DGRAM	2019-03-17 21:32:11 -07:00
tls	net/tls: Inform user space about send buffer availability	2019-03-13 14:16:44 -07:00
unix	io_uring-2019-03-06	2019-03-08 14:48:40 -08:00
vmw_vsock	vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock	2019-03-08 15:15:44 -08:00
wimax
wireless	Merge remote-tracking branch 'net-next/master' into mac80211-next	2019-02-22 13:48:13 +01:00
x25	net/x25: reset state in x25_connect()	2019-03-11 15:40:14 -07:00
xdp	xsk: fix umem memory leak on cleanup	2019-03-16 01:27:51 +01:00
xfrm	xfrm: Fix inbound traffic via XFRM interfaces across network namespaces	2019-02-18 10:58:54 +01:00
compat.c	Merge branch 'timers-2038-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-03-05 14:08:26 -08:00
Kconfig	net: devlink: turn devlink into a built-in	2019-02-26 08:49:05 -08:00
Makefile	net: split out functions related to registering inflight socket files	2019-02-28 08:24:23 -07:00
socket.c	net: add documentation to socket.c	2019-03-15 15:29:47 -07:00
sysctl_net.c