Colin Ian King 80cff3e116 xfs: fix return of uninitialized value in variable error ... [ Upstream commit 3b6dd9a9aeeada19d0c820ff68e979243a888bb6 ] A previous commit removed a call to xfs_attr3_leaf_read that assigned an error return code to variable error. We now have a few early error return paths to label 'out' that return error if error is set; however error now is uninitialized so potentially garbage is being returned. Fix this by setting error to zero to restore the original behaviour where error was zero at the label 'restart'. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 07120f1abd ("xfs: Add xfs_has_attr and subroutines") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-05-14 09:50:34 +02:00
..
libxfs	xfs: fix return of uninitialized value in variable error	2021-05-14 09:50:34 +02:00
scrub	xfs: directory scrub should check the null bestfree entries too	2020-11-18 09:23:50 -08:00
Kconfig	xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n	2020-10-16 15:34:28 -07:00
kmem.c	xfs: remove kmem_realloc()	2020-09-06 18:05:51 -07:00
kmem.h	xfs: Remove kmem_zalloc_large()	2020-09-15 20:52:41 -07:00
Makefile	xfs: refactor log recovery item sorting into a generic dispatch structure	2020-05-08 08:49:58 -07:00
mrlock.h
xfs_acl.c	xfs: Remove kmem_zalloc_large()	2020-09-15 20:52:41 -07:00
xfs_acl.h	xfs: improve xfs_forget_acl	2020-03-02 20:55:55 -08:00
xfs_aops.c	xfs: fix missing CoW blocks writeback conversion retry	2020-11-04 08:52:47 -08:00
xfs_aops.h
xfs_attr_inactive.c	xfs: cleanup xfs_idestroy_fork	2020-05-19 09:40:59 -07:00
xfs_attr_list.c	xfs: Convert xfs_attr_sf macros to inline functions	2020-09-15 20:52:42 -07:00
xfs_bio_io.c
xfs_bmap_item.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_bmap_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_bmap_util.c	xfs: fix fallocate functions when rtextsize is larger than 1	2020-10-21 09:05:19 -07:00
xfs_bmap_util.h
xfs_buf_item_recover.c	xfs: fix finobt btree block recovery ordering	2020-09-30 07:28:52 -07:00
xfs_buf_item.c	xfs: remove xlog_recover_iodone	2020-09-15 20:52:39 -07:00
xfs_buf_item.h	xfs: move the buffer retry logic to xfs_buf.c	2020-09-15 20:52:38 -07:00
xfs_buf.c	xfs: reuse _xfs_buf_read for re-reading the superblock	2020-09-15 20:52:39 -07:00
xfs_buf.h	xfs: reuse _xfs_buf_read for re-reading the superblock	2020-09-15 20:52:39 -07:00
xfs_dir2_readdir.c	xfs: move the fork format fields into struct xfs_ifork	2020-05-19 09:40:58 -07:00
xfs_discard.c	xfs: remove XFS_BUF_TO_AGF	2020-03-11 09:11:39 -07:00
xfs_discard.h
xfs_dquot_item_recover.c	xfs: rename the ondisk dquot d_flags to d_type	2020-07-28 20:24:14 -07:00
xfs_dquot_item.c	xfs: stop using q_core.d_id in the quota code	2020-07-28 20:24:14 -07:00
xfs_dquot_item.h	xfs: factor out quotaoff intent AIL removal and memory free	2020-03-18 08:12:23 -07:00
xfs_dquot.c	xfs: fix some comments	2020-09-25 11:34:07 -07:00
xfs_dquot.h	xfs: refactor default quota grace period setting code	2020-09-15 20:52:40 -07:00
xfs_error.c	xfs: random buffer write failure errortag	2020-05-07 08:27:48 -07:00
xfs_error.h	xfs: xfs_buf_corruption_error should take __this_address	2020-03-12 07:58:12 -07:00
xfs_export.c	xfs: delete duplicated words + other fixes	2020-08-05 08:49:58 -07:00
xfs_export.h
xfs_extent_busy.c
xfs_extent_busy.h
xfs_extfree_item.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_extfree_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_file.c	xfs: fix fallocate functions when rtextsize is larger than 1	2020-10-21 09:05:19 -07:00
xfs_filestream.c	xfs: drop the obsolete comment on filestream locking	2020-09-25 11:34:08 -07:00
xfs_filestream.h
xfs_fsmap.c	xfs: fix deadlock and streamline xfs_getfsmap performance	2020-10-07 08:40:29 -07:00
xfs_fsmap.h	xfs: fix deadlock and streamline xfs_getfsmap performance	2020-10-07 08:40:29 -07:00
xfs_fsops.c	xfs: remove unused shutdown types	2020-05-07 08:27:48 -07:00
xfs_fsops.h
xfs_globals.c
xfs_health.c
xfs_icache.c	xfs: Remove unneeded semicolon	2020-09-15 20:52:42 -07:00
xfs_icache.h	xfs: remove SYNC_WAIT and SYNC_TRYLOCK	2020-07-14 08:47:33 -07:00
xfs_icreate_item.c	xfs: Remove kmem_zone_zalloc() usage	2020-07-28 20:24:14 -07:00
xfs_icreate_item.h
xfs_inode_item_recover.c	xfs: widen ondisk inode timestamps to deal with y2038+	2020-09-15 20:52:41 -07:00
xfs_inode_item.c	xfs: widen ondisk inode timestamps to deal with y2038+	2020-09-15 20:52:41 -07:00
xfs_inode_item.h	xfs: move the buffer retry logic to xfs_buf.c	2020-09-15 20:52:38 -07:00
xfs_inode.c	xfs: drop extra transaction roll from inode extent truncate	2020-09-21 09:54:29 -07:00
xfs_inode.h	xfs: widen ondisk inode timestamps to deal with y2038+	2020-09-15 20:52:41 -07:00
xfs_ioctl.c	xfs: fix deadlock and streamline xfs_getfsmap performance	2020-10-07 08:40:29 -07:00
xfs_ioctl.h	xfs: embedded the attrlist cursor into struct xfs_attr_list_context	2020-03-02 20:55:55 -08:00
xfs_ioctl32.c	xfs: lift cursor copy in/out into xfs_ioc_attr_list	2020-03-02 20:55:54 -08:00
xfs_ioctl32.h
xfs_iomap.c	xfs: don't allow NOWAIT DIO across extent boundaries	2020-11-19 08:59:11 -08:00
xfs_iomap.h
xfs_iops.c	xfs: Fix assert failure in xfs_setattr_size()	2021-03-07 12:34:05 +01:00
xfs_iops.h
xfs_itable.c	xfs: move the fork format fields into struct xfs_ifork	2020-05-19 09:40:58 -07:00
xfs_itable.h
xfs_iwalk.c	xfs: ensure inobt record walks always make forward progress	2020-11-18 09:23:51 -08:00
xfs_iwalk.h
xfs_linux.h	xfs: fix fallocate functions when rtextsize is larger than 1	2020-10-21 09:05:19 -07:00
xfs_log_cil.c	xfs: delete duplicated words + other fixes	2020-08-05 08:49:58 -07:00
xfs_log_priv.h	xfs: Modify xlog_ticket_alloc() to use kernel's MM API	2020-07-28 20:24:14 -07:00
xfs_log_recover.c	xfs: cancel intents immediately if process_intents fails	2020-10-21 16:28:46 -07:00
xfs_log.c	xfs: expose the log push threshold	2020-10-07 08:40:29 -07:00
xfs_log.h	xfs: expose the log push threshold	2020-10-07 08:40:29 -07:00
xfs_message.c	xfs: refactor ratelimited buffer error messages into helper	2020-05-07 08:27:46 -07:00
xfs_message.h	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
xfs_mount.c	xfs: return corresponding errcode if xfs_initialize_perag() fail	2020-11-18 09:23:51 -08:00
xfs_mount.h	xfs: remove xfs_getsb	2020-09-15 20:52:39 -07:00
xfs_mru_cache.c
xfs_mru_cache.h
xfs_ondisk.h	xfs: Remove typedef xfs_attr_shortform_t	2020-09-15 20:52:42 -07:00
xfs_pnfs.c	xfs: fix a missing unlock on error in xfs_fs_map_blocks	2020-11-11 08:07:37 -08:00
xfs_pnfs.h
xfs_pwork.c	block: remove the bd_queue field from struct block_device	2020-07-01 08:08:20 -06:00
xfs_pwork.h
xfs_qm_bhv.c	xfs: rename XFS_DQ_{USER,GROUP,PROJ} to XFS_DQTYPE_*	2020-07-28 20:24:14 -07:00
xfs_qm_syscalls.c	xfs: refactor default quota grace period setting code	2020-09-15 20:52:40 -07:00
xfs_qm.c	xfs: do the ASSERT for the arguments O_{u,g,p}dqpp	2020-10-07 08:40:29 -07:00
xfs_qm.h	xfs: refactor quota expiration timer modification	2020-09-15 20:52:40 -07:00
xfs_quota.h	xfs: move the buffer retry logic to xfs_buf.c	2020-09-15 20:52:38 -07:00
xfs_quotaops.c	xfs: create xfs_dqtype_t to represent quota types	2020-07-28 20:24:14 -07:00
xfs_refcount_item.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_refcount_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_reflink.c	xfs: only flush the unshared range in xfs_reflink_unshare	2020-11-04 17:41:56 -08:00
xfs_reflink.h	xfs: move helpers that lock and unlock two inodes against userspace IO	2020-07-06 10:46:57 -07:00
xfs_rmap_item.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_rmap_item.h	xfs: refactor intent item RECOVERED flag into the log item	2020-05-08 08:50:01 -07:00
xfs_rtalloc.c	xfs: annotate grabbing the realtime bitmap/summary locks in growfs	2020-10-13 08:41:31 -07:00
xfs_rtalloc.h
xfs_stats.c	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_stats.h	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_super.c	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-10-24 12:26:05 -07:00
xfs_super.h
xfs_symlink.c	xfs: move the fork format fields into struct xfs_ifork	2020-05-19 09:40:58 -07:00
xfs_symlink.h
xfs_sysctl.c	xfs: remove deprecated sysctl options	2020-09-25 11:34:08 -07:00
xfs_sysctl.h
xfs_sysfs.c
xfs_sysfs.h	xfs: Fix UBSAN null-ptr-deref in xfs_sysfs_init	2020-08-07 11:50:17 -07:00
xfs_trace.c	xfs: support bulk loading of staged btrees	2020-03-18 08:12:23 -07:00
xfs_trace.h	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_trans_ail.c	xfs: delete duplicated words + other fixes	2020-08-05 08:49:58 -07:00
xfs_trans_buf.c	xfs: simplify xfs_trans_getsb	2020-09-15 20:52:39 -07:00
xfs_trans_dquot.c	xfs: fix the indent in xfs_trans_mod_dquot	2020-10-07 08:40:29 -07:00
xfs_trans_priv.h	xfs: refactor adding recovered intent items to the log	2020-05-08 08:50:00 -07:00
xfs_trans.c	xfs: do the assert for all the log done items in xfs_trans_cancel	2020-09-25 11:34:07 -07:00
xfs_trans.h	xfs: periodically relog deferred intent items	2020-10-07 08:40:28 -07:00
xfs_xattr.c	xfs: remove duplicate headers	2020-05-08 08:51:34 -07:00
xfs.h