Jason Gunthorpe daa72300c9 vfio/fsl-mc: Re-order vfio_fsl_mc_probe() ... [ Upstream commit 2b1fe162e584a88ec7f12a651a2a50f94dd8cfac ] vfio_add_group_dev() must be called only after all of the private data in vdev is fully setup and ready, otherwise there could be races with user space instantiating a device file descriptor and starting to call ops. For instance vfio_fsl_mc_reflck_attach() sets vdev->reflck and vfio_fsl_mc_open(), called by fops open, unconditionally derefs it, which will crash if things get out of order. This driver started life with the right sequence, but two commits added stuff after vfio_add_group_dev(). Fixes: 2e0d29561f ("vfio/fsl-mc: Add irq infrastructure for fsl-mc devices") Fixes: f2ba7e8c94 ("vfio/fsl-mc: Added lock support in preparation for interrupt handling") Co-developed-by: Diana Craciun OSS <diana.craciun@oss.nxp.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Message-Id: <5-v3-225de1400dfc+4e074-vfio1_jgg@nvidia.com> Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-05-14 09:50:25 +02:00
..
Kconfig
Makefile	vfio/fsl-mc: Add irq infrastructure for fsl-mc devices	2020-10-12 11:33:06 -06:00
vfio_fsl_mc_intr.c	vfio/fsl-mc: Make vfio_fsl_mc_irqs_allocate static	2020-11-03 11:07:40 -07:00
vfio_fsl_mc_private.h	vfio/fsl-mc: Add read/write support for fsl-mc devices	2020-10-12 11:33:27 -06:00
vfio_fsl_mc.c	vfio/fsl-mc: Re-order vfio_fsl_mc_probe()	2021-05-14 09:50:25 +02:00