Ming Lei 544fbd16a4 block: deactivate blk_stat timer in wbt_disable_default() ... rwb_enabled() can't be changed when there is any inflight IO. wbt_disable_default() may set rwb->wb_normal as zero, however the blk_stat timer may still be pending, and the timer function will update wrb->wb_normal again. This patch introduces blk_stat_deactivate() and applies it in wbt_disable_default(), then the following IO hang triggered when running parted & switching io scheduler can be fixed: [ 369.937806] INFO: task parted:3645 blocked for more than 120 seconds. [ 369.938941] Not tainted 4.20.0-rc6-00284-g906c801e5248 #498 [ 369.939797] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 369.940768] parted D 0 3645 3239 0x00000000 [ 369.941500] Call Trace: [ 369.941874] ? __schedule+0x6d9/0x74c [ 369.942392] ? wbt_done+0x5e/0x5e [ 369.942864] ? wbt_cleanup_cb+0x16/0x16 [ 369.943404] ? wbt_done+0x5e/0x5e [ 369.943874] schedule+0x67/0x78 [ 369.944298] io_schedule+0x12/0x33 [ 369.944771] rq_qos_wait+0xb5/0x119 [ 369.945193] ? karma_partition+0x1c2/0x1c2 [ 369.945691] ? wbt_cleanup_cb+0x16/0x16 [ 369.946151] wbt_wait+0x85/0xb6 [ 369.946540] __rq_qos_throttle+0x23/0x2f [ 369.947014] blk_mq_make_request+0xe6/0x40a [ 369.947518] generic_make_request+0x192/0x2fe [ 369.948042] ? submit_bio+0x103/0x11f [ 369.948486] ? __radix_tree_lookup+0x35/0xb5 [ 369.949011] submit_bio+0x103/0x11f [ 369.949436] ? blkg_lookup_slowpath+0x25/0x44 [ 369.949962] submit_bio_wait+0x53/0x7f [ 369.950469] blkdev_issue_flush+0x8a/0xae [ 369.951032] blkdev_fsync+0x2f/0x3a [ 369.951502] do_fsync+0x2e/0x47 [ 369.951887] __x64_sys_fsync+0x10/0x13 [ 369.952374] do_syscall_64+0x89/0x149 [ 369.952819] entry_SYSCALL_64_after_hwframe+0x49/0xbe [ 369.953492] RIP: 0033:0x7f95a1e729d4 [ 369.953996] Code: Bad RIP value. [ 369.954456] RSP: 002b:00007ffdb570dd48 EFLAGS: 00000246 ORIG_RAX: 000000000000004a [ 369.955506] RAX: ffffffffffffffda RBX: 000055c2139c6be0 RCX: 00007f95a1e729d4 [ 369.956389] RDX: 0000000000000001 RSI: 0000000000001261 RDI: 0000000000000004 [ 369.957325] RBP: 0000000000000002 R08: 0000000000000000 R09: 000055c2139c6ce0 [ 369.958199] R10: 0000000000000000 R11: 0000000000000246 R12: 000055c2139c0380 [ 369.959143] R13: 0000000000000004 R14: 0000000000000100 R15: 0000000000000008 Cc: stable@vger.kernel.org Cc: Paolo Valente <paolo.valente@linaro.org> Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2018-12-12 06:47:51 -07:00
..
partitions
badblocks.c
bfq-cgroup.c	blkcg: fix ref count issue with bio_blkcg() using task_css	2018-12-07 22:26:36 -07:00
bfq-iosched.c	Linux 4.20-rc6	2018-12-09 17:45:40 -07:00
bfq-iosched.h	block, bfq: fix decrement of num_active_groups	2018-12-07 07:40:07 -07:00
bfq-wf2q.c	block, bfq: fix decrement of num_active_groups	2018-12-07 07:40:07 -07:00
bio-integrity.c
bio.c	block: delete part_round_stats and switch to less precise counting	2018-12-10 08:30:37 -07:00
blk-cgroup.c	blkcg: rename blkg_try_get() to blkg_tryget()	2018-12-07 22:26:38 -07:00
blk-core.c	block: delete part_round_stats and switch to less precise counting	2018-12-10 08:30:37 -07:00
blk-exec.c
blk-flush.c	block: add queue_is_mq() helper	2018-11-16 08:34:06 -07:00
blk-integrity.c
blk-ioc.c	block: remove the queue_lock indirection	2018-11-15 12:17:28 -07:00
blk-iolatency.c	block: convert io-latency to use rq_qos_wait	2018-12-07 22:26:38 -07:00
blk-lib.c	block: fix 32 bit overflow in __blkdev_issue_discard()	2018-11-14 08:17:18 -07:00
blk-map.c
blk-merge.c	block: delete part_round_stats and switch to less precise counting	2018-12-10 08:30:37 -07:00
blk-mq-cpumap.c
blk-mq-debugfs-zoned.c
blk-mq-debugfs.c	block: remove QUEUE_FLAG_BYPASS and ->bypass	2018-11-15 12:13:15 -07:00
blk-mq-debugfs.h
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	block: fix attempt to assign NULL io_context	2018-11-20 19:12:46 -07:00
blk-mq-sched.h	block: Remove bio->bi_ioc	2018-11-19 19:03:44 -07:00
blk-mq-sysfs.c	block: move queues types to the block layer	2018-12-04 11:38:17 -07:00
blk-mq-tag.c	sbitmap: optimize wakeup check	2018-11-30 14:48:04 -07:00
blk-mq-tag.h
blk-mq-virtio.c
blk-mq.c	block: return just one value from part_in_flight	2018-12-10 08:30:38 -07:00
blk-mq.h	block: return just one value from part_in_flight	2018-12-10 08:30:38 -07:00
blk-pm.c	block: remove the queue_lock indirection	2018-11-15 12:17:28 -07:00
blk-pm.h	block: remove the queue_lock indirection	2018-11-15 12:17:28 -07:00
blk-rq-qos.c	block: add rq_qos_wait to rq_qos	2018-12-07 22:26:38 -07:00
blk-rq-qos.h	block: add rq_qos_wait to rq_qos	2018-12-07 22:26:38 -07:00
blk-settings.c	block: use atomic bitops for ->queue_flags	2018-11-15 12:13:19 -07:00
blk-softirq.c	block: remove a few unused exports	2018-11-15 12:13:25 -07:00
blk-stat.c	block: remove a few unused exports	2018-11-15 12:13:25 -07:00
blk-stat.h	block: deactivate blk_stat timer in wbt_disable_default()	2018-12-12 06:47:51 -07:00
blk-sysfs.c	block: only allow polling if a poll queue_map exists	2018-12-04 11:38:19 -07:00
blk-throttle.c	blkcg: consolidate bio_issue_init() to be a part of core	2018-12-07 22:26:37 -07:00
blk-timeout.c	block: don't hold the queue_lock over blk_abort_request	2018-11-15 12:13:18 -07:00
blk-wbt.c	block: deactivate blk_stat timer in wbt_disable_default()	2018-12-12 06:47:51 -07:00
blk-wbt.h
blk-zoned.c	block: add queue_is_mq() helper	2018-11-16 08:34:06 -07:00
blk.h	block: sum requests in the plug structure	2018-11-26 10:35:22 -07:00
bounce.c	blkcg: remove bio->bi_css and instead use bio->bi_blkg	2018-12-07 22:26:37 -07:00
bsg-lib.c
bsg.c	block: add queue_is_mq() helper	2018-11-16 08:34:06 -07:00
cmdline-parser.c
compat_ioctl.c
elevator.c	block: add queue_is_mq() helper	2018-11-16 08:34:06 -07:00
genhd.c	block: return just one value from part_in_flight	2018-12-10 08:30:38 -07:00
ioctl.c
ioprio.c
Kconfig
Kconfig.iosched
kyber-iosched.c
Makefile
mq-deadline.c
opal_proto.h
partition-generic.c	block: return just one value from part_in_flight	2018-12-10 08:30:38 -07:00
scsi_ioctl.c
sed-opal.c
t10-pi.c