kernel_optimize_test/drivers/firewire
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
core-card.c
core-cdev.c idr: Return the deleted entry from idr_remove 2017-02-13 21:44:03 -05:00
core-device.c scripts/spelling.txt: add "intialization" pattern and fix typo instances 2017-02-27 18:43:47 -08:00
core-iso.c
core-topology.c drivers, firewire: convert fw_node.ref_count from atomic_t to refcount_t 2017-03-23 13:57:19 +01:00
core-transaction.c firewire: core: use correct vendor/model IDs 2015-02-02 21:56:03 +01:00
core.h drivers, firewire: convert fw_node.ref_count from atomic_t to refcount_t 2017-03-23 13:57:19 +01:00
init_ohci1394_dma.c
Kconfig
Makefile
net.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
nosy-user.h
nosy.c firewire: nosy: do not ignore errors in ioremap_nocache() 2016-10-09 11:38:11 +02:00
nosy.h
ohci.c firewire: ohci: propagate return code from soft_reset to probe and resume 2015-11-05 14:25:31 +01:00
ohci.h
sbp2.c scsi: Do not set cmd_per_lun to 1 in the host template 2015-05-31 18:06:28 -07:00