Xin Long 3106ecb43a sctp: not disable bh in the whole sctp_get_port_local() ... With disabling bh in the whole sctp_get_port_local(), when snum == 0 and too many ports have been used, the do-while loop will take the cpu for a long time and cause cpu stuck: [ ] watchdog: BUG: soft lockup - CPU#11 stuck for 22s! [ ] RIP: 0010:native_queued_spin_lock_slowpath+0x4de/0x940 [ ] Call Trace: [ ] _raw_spin_lock+0xc1/0xd0 [ ] sctp_get_port_local+0x527/0x650 [sctp] [ ] sctp_do_bind+0x208/0x5e0 [sctp] [ ] sctp_autobind+0x165/0x1e0 [sctp] [ ] sctp_connect_new_asoc+0x355/0x480 [sctp] [ ] __sctp_connect+0x360/0xb10 [sctp] There's no need to disable bh in the whole function of sctp_get_port_local. So fix this cpu stuck by removing local_bh_disable() called at the beginning, and using spin_lock_bh() instead. The same thing was actually done for inet_csk_get_port() in Commit ea8add2b19 ("tcp/dccp: better use of ephemeral ports in bind()"). Thanks to Marcelo for pointing the buggy code out. v1->v2: - use cond_resched() to yield cpu to other tasks if needed, as Eric noticed. Fixes: 1da177e4c3 ("Linux-2.6.12-rc2") Reported-by: Ying Xu <yinxu@redhat.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-08-24 15:50:17 -07:00
..
associola.c	sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket	2020-06-25 16:11:33 -07:00
auth.c	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00
bind_addr.c	sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket	2020-06-25 16:11:33 -07:00
chunk.c
debug.c
diag.c
endpointola.c
input.c
inqueue.c
ipv6.c	net/ipv6: remove compat_ipv6_{get,set}sockopt	2020-07-19 18:16:41 -07:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile
objcnt.c
offload.c
output.c
outqueue.c
primitive.c
proc.c
protocol.c	sctp: remove redundant initialization of variable status	2020-07-24 17:10:13 -07:00
sm_make_chunk.c	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2020-06-01 12:00:10 -07:00
sm_sideeffect.c	sctp: Don't add the shutdown timer if its already been added	2020-05-19 15:46:52 -07:00
sm_statefuns.c	sctp: Start shutdown on association restart if in SHUTDOWN-SENT state and socket is closed	2020-05-22 15:47:59 -07:00
sm_statetable.c
socket.c	sctp: not disable bh in the whole sctp_get_port_local()	2020-08-24 15:50:17 -07:00
stream_interleave.c
stream_sched_prio.c
stream_sched_rr.c
stream_sched.c
stream.c	net: sctp: Fix negotiation of the number of data streams.	2020-08-20 16:37:37 -07:00
sysctl.c
transport.c
tsnmap.c
ulpevent.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-05-31 17:48:46 -07:00
ulpqueue.c