Matt Redfearn 34563769e4 virtio: console: Unlock vqs while freeing buffers ... Commit c6017e793b ("virtio: console: add locks around buffer removal in port unplug path") added locking around the freeing of buffers in the vq. However, when free_buf() is called with can_sleep = true and rproc is enabled, it calls dma_free_coherent() directly, requiring interrupts to be enabled. Currently a WARNING is triggered due to the spin locking around free_buf, with a call stack like this: WARNING: CPU: 3 PID: 121 at ./include/linux/dma-mapping.h:433 free_buf+0x1a8/0x288 Call Trace: [<8040c538>] show_stack+0x74/0xc0 [<80757240>] dump_stack+0xd0/0x110 [<80430d98>] __warn+0xfc/0x130 [<80430ee0>] warn_slowpath_null+0x2c/0x3c [<807e7c6c>] free_buf+0x1a8/0x288 [<807ea590>] remove_port_data+0x50/0xac [<807ea6a0>] unplug_port+0xb4/0x1bc [<807ea858>] virtcons_remove+0xb0/0xfc [<807b6734>] virtio_dev_remove+0x58/0xc0 [<807f918c>] __device_release_driver+0xac/0x134 [<807f924c>] device_release_driver+0x38/0x50 [<807f7edc>] bus_remove_device+0xfc/0x130 [<807f4b74>] device_del+0x17c/0x21c [<807f4c38>] device_unregister+0x24/0x38 [<807b6b50>] unregister_virtio_device+0x28/0x44 Fix this by restructuring the loops to allow the locks to only be taken where it is necessary to protect the vqs, and release it while the buffer is being freed. Fixes: c6017e793b ("virtio: console: add locks around buffer removal in port unplug path") Cc: stable@vger.kernel.org Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>		2016-10-31 00:21:44 +02:00
..
agp	agp/intel: Flush chipset writes after updating a single PTE	2016-08-18 22:36:23 +01:00
hw_random	hwrng: core - Don't use a stack buffer in add_early_randomness()	2016-10-19 11:20:21 +08:00
ipmi	ipmi: fix crash on reading version from proc after unregisted bmc	2016-10-03 09:09:47 -05:00
mwave	char/mwave: remove custom BOOLEAN type	2016-08-31 14:22:49 +02:00
pcmcia	TTY and Serial driver update for 4.7-rc1	2016-05-20 20:57:27 -07:00
tpm	Revert "tpm/tpm_crb: implement tpm crb idle state"	2016-09-27 12:02:13 +03:00
xilinx_hwicap
xillybus	char: xillybus: Fix spelling mistake and comment	2016-08-31 14:47:54 +02:00
apm-emulation.c
applicom.c
applicom.h
bfin-otp.c	miscdevice: Use module_misc_device() macro	2016-08-31 14:12:35 +02:00
bsr.c
ds1302.c
ds1620.c
dsp56k.c	dsp56k: prevent a harmless underflow	2016-07-14 16:21:53 +09:00
dtlk.c
efirtc.c
generic_nvram.c
hangcheck-timer.c
hpet.c
Kconfig	RTC for 4.8	2016-08-05 09:48:22 -04:00
lp.c
Makefile	RTC for 4.8	2016-08-05 09:48:22 -04:00
mbcs.c
mbcs.h
mem.c	drivers: char: mem: Check {read,write}_kmem() addresses	2016-08-31 15:21:18 +02:00
misc.c
mmtimer.c
mspec.c
nsc_gpio.c
nvram.c
nwbutton.c
nwbutton.h
nwflash.c
pc8736x_gpio.c
powernv-op-panel.c	powerpc/powernv: Add driver for operator panel on FSP machines	2016-06-29 17:33:46 +10:00
ppdev.c	ppdev: use new parport device model	2016-08-31 14:22:49 +02:00
ps3flash.c
random.c	This adds a new gcc plugin named "latent_entropy". It is designed to	2016-10-15 10:03:15 -07:00
raw.c
rtc.c
scx200_gpio.c
snsc_event.c
snsc.c	snsc: check return value of class_create	2016-08-31 14:47:54 +02:00
snsc.h
sonypi.c	fs: Replace current_fs_time() with current_time()	2016-09-27 21:06:22 -04:00
tb0219.c	mips: separate extable.h, switch module.h to it	2016-10-05 18:36:18 -04:00
tile-srom.c	tile-srom: avoid krealloc(... __GFP_ZERO) pattern	2016-08-30 14:45:50 +02:00
tlclk.c
toshiba.c
ttyprintk.c	ttyprintk: Neaten and simplify printing	2016-09-13 17:30:17 +02:00
uv_mmtimer.c
virtio_console.c	virtio: console: Unlock vqs while freeing buffers	2016-10-31 00:21:44 +02:00