Finn Thain 6c8b89ea55 nubus: Call proc_mkdir() not more than once per slot directory ... This patch fixes the following WARNING. proc_dir_entry 'nubus/a' already registered Modules linked in: CPU: 0 PID: 1 Comm: swapper Tainted: G W 4.13.0-00036-gd57552077387 #1 Stack from 01c1bd9c: 01c1bd9c 003c2c8b 01c1bdc0 0001b0fe 00000000 00322f4a 01c43a20 01c43b0c 01c8c420 01c1bde8 0001b1b8 003a4ac3 00000148 000faa26 00000009 00000000 01c1bde0 003a4b6c 01c1bdfc 01c1be20 000faa26 003a4ac3 00000148 003a4b6c 01c43a71 01c8c471 01c10000 00326430 0043d00c 00000005 01c71a00 0020bce0 00322964 01c1be38 000fac04 01c43a20 01c8c420 01c1bee0 01c8c420 01c1be50 000fac4c 01c1bee0 00000000 01c43a20 00000000 01c1bee8 0020bd26 01c1bee0 Call Trace: [<0001b0fe>] __warn+0xae/0xde [<00322f4a>] memcmp+0x0/0x5c [<0001b1b8>] warn_slowpath_fmt+0x2e/0x36 [<000faa26>] proc_register+0xbe/0xd8 [<000faa26>] proc_register+0xbe/0xd8 [<00326430>] sprintf+0x0/0x20 [<0020bce0>] nubus_proc_attach_device+0x0/0x1b8 [<00322964>] strcpy+0x0/0x22 [<000fac04>] proc_mkdir_data+0x64/0x96 [<000fac4c>] proc_mkdir+0x16/0x1c [<0020bd26>] nubus_proc_attach_device+0x46/0x1b8 [<0020bce0>] nubus_proc_attach_device+0x0/0x1b8 [<00322964>] strcpy+0x0/0x22 [<00001ba6>] kernel_pg_dir+0xba6/0x1000 [<004339a2>] proc_bus_nubus_add_devices+0x1a/0x2e [<000faa40>] proc_create_data+0x0/0xf2 [<0003297c>] parse_args+0x0/0x2d4 [<00433a08>] nubus_proc_init+0x52/0x5a [<00433944>] nubus_init+0x0/0x44 [<00433982>] nubus_init+0x3e/0x44 [<000020dc>] do_one_initcall+0x38/0x196 [<000020a4>] do_one_initcall+0x0/0x196 [<0003297c>] parse_args+0x0/0x2d4 [<00322964>] strcpy+0x0/0x22 [<00040004>] __up_read+0xe/0x40 [<004231d4>] repair_env_string+0x0/0x7a [<0042312e>] kernel_init_freeable+0xee/0x194 [<00423146>] kernel_init_freeable+0x106/0x194 [<00433944>] nubus_init+0x0/0x44 [<000a6000>] kfree+0x0/0x156 [<0032768c>] kernel_init+0x0/0xda [<00327698>] kernel_init+0xc/0xda [<0032768c>] kernel_init+0x0/0xda [<00002a90>] ret_from_kernel_thread+0xc/0x14 ---[ end trace 14a6d619908ea253 ]--- ------------[ cut here ]------------ This gets repeated with each additional functional reasource. The problem here is the call to proc_mkdir() when the directory already exists. Each nubus_board gets a directory, such as /proc/bus/nubus/s/ where s is the hex slot number. Therefore, store the 'procdir' pointer in struct nubus_board instead of struct nubus_dev. Tested-by: Stan Johnson <userm57@yahoo.com> Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>		2018-01-16 16:47:29 +01:00
..
accessibility
acpi	ACPI fix for v4.15-rc1	2017-11-17 14:51:24 -08:00
amba	A couple of dma-mapping updates:	2017-11-14 16:54:12 -08:00
android	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
ata	Merge branch 'for-4.15' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata	2017-11-15 14:11:41 -08:00
atm	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
auxdisplay
base	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
bcma	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-11-15 11:56:19 -08:00
block	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
bluetooth
bus	ARM: SoC driver updates for v4.15	2017-11-16 16:05:01 -08:00
cdrom	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
char	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-26 14:11:54 -08:00
clk	We have two changes to the core framework this time around. The first being a	2017-11-17 20:04:24 -08:00
clocksource	- final batch of "non trivial" timer conversions (multi-tree dependencies,	2017-11-23 16:29:05 +01:00
connector
cpufreq
cpuidle	powerpc updates for 4.15	2017-11-16 12:47:46 -08:00
crypto	powerpc updates for 4.15	2017-11-16 12:47:46 -08:00
dax	libnvdimm for 4.15	2017-11-17 09:51:57 -08:00
dca
devfreq
dio
dma	dmaengine updates for 4.15-rc1	2017-11-14 16:49:31 -08:00
dma-buf	Tracing updates for 4.15:	2017-11-17 14:58:01 -08:00
edac	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
eisa
extcon	USB/PHY patches for 4.15-rc1	2017-11-13 21:14:07 -08:00
firewire
firmware	drivers/firmware: psci: Convert timers to use timer_setup()	2017-11-21 15:46:44 -08:00
fmc
fpga	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
fsi
gpio	This is the bulk of pin control changes for the v4.15	2017-11-16 10:57:11 -08:00
gpu	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-25 08:37:16 -10:00
hid	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
hsi	HSI changes for the v4.15 series	2017-11-15 13:35:43 -08:00
hv	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
hwmon	hwmon: (w83793) Remove duplicate NULL check	2017-11-16 01:03:19 -08:00
hwspinlock	hwspinlock update for v4.15	2017-11-17 20:16:20 -08:00
hwtracing	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
i2c	Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 11:54:55 -08:00
ide	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide	2017-11-19 08:04:41 -10:00
idle
iio	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
infiniband	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
input	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
iommu	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
ipack
irqchip	Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-26 14:39:20 -08:00
isdn	treewide: setup_timer() -> timer_setup() (2 field)	2017-11-21 15:57:09 -08:00
leds	LED updates for 4.15rc1	2017-11-14 18:09:31 -08:00
lightnvm	lightnvm: Convert timers to use timer_setup()	2017-11-21 15:46:44 -08:00
macintosh
mailbox	Change to POLL api and fixes for FlexRM and OMAP driver	2017-11-15 13:39:18 -08:00
mcb
md	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2017-11-17 10:56:56 -08:00
media	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
memory	ARM: SoC driver updates for v4.15	2017-11-16 16:05:01 -08:00
memstick	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
message	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
mfd	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
misc	lkdtm: include WARN format string	2017-11-17 16:10:01 -08:00
mmc	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
mtd	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-25 08:37:16 -10:00
mux
net	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-25 08:37:16 -10:00
nfc	treewide: setup_timer() -> timer_setup() (2 field)	2017-11-21 15:57:09 -08:00
ntb	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
nubus	nubus: Call proc_mkdir() not more than once per slot directory	2018-01-16 16:47:29 +01:00
nvdimm	libnvdimm for 4.15	2017-11-17 09:51:57 -08:00
nvme	nvmet_fc: fix better length checking	2017-11-16 11:27:04 -07:00
nvmem	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
of	DeviceTree fixes for 4.15:	2017-11-20 21:38:41 -10:00
opp
oprofile
parisc
parport	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
pci	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-26 14:11:54 -08:00
pcmcia	drivers/pcmcia/sa1111_badge4.c: avoid unused function warning	2017-11-17 16:10:04 -08:00
perf	arm64 updates for 4.15	2017-11-15 10:56:56 -08:00
phy	USB/PHY patches for 4.15-rc1	2017-11-13 21:14:07 -08:00
pinctrl	This is the bulk of pin control changes for the v4.15	2017-11-16 10:57:11 -08:00
platform	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-25 08:37:16 -10:00
pnp
power	power supply and reset changes for the v4.15 series	2017-11-15 13:37:15 -08:00
powercap
pps	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
ps3
ptp	xen: features and fixes for v4.15-rc1	2017-11-16 13:06:27 -08:00
pwm	pwm: Changes for v4.15-rc1	2017-11-22 21:09:18 -10:00
rapidio	Merge branch 'akpm' (patches from Andrew)	2017-11-17 16:56:17 -08:00
ras
regulator	- New Drivers	2017-11-16 09:15:57 -08:00
remoteproc	remoteproc updates for v4.15	2017-11-17 20:14:10 -08:00
reset	ARM: SoC driver updates for v4.15	2017-11-16 16:05:01 -08:00
rpmsg	rpmsg updates for v4.15	2017-11-17 20:12:08 -08:00
rtc	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-25 08:37:16 -10:00
s390	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
sbus	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc	2017-11-17 20:21:44 -08:00
scsi	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-25 08:37:16 -10:00
sfi
sh	A couple of dma-mapping updates:	2017-11-14 16:54:12 -08:00
sn
soc	ARM: SoC driver updates for v4.15	2017-11-16 16:05:01 -08:00
spi
spmi
ssb
staging	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
target	Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-11-25 08:37:16 -10:00
tc
tee
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2017-11-17 14:31:27 -08:00
thunderbolt	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
tty	treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts	2017-11-21 16:35:54 -08:00
uio
usb	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
uwb	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
vfio	VFIO Updates for Linux v4.15	2017-11-14 16:47:47 -08:00
vhost	Merge branch 'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:08:18 -08:00
video	fbdev changes for v4.15:	2017-11-20 21:50:24 -10:00
virt
virtio	virtio_balloon: fix deadlock on OOM	2017-11-14 23:57:38 +02:00
vlynq
vme	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
w1	Char/Misc patches for 4.15-rc1	2017-11-16 09:10:59 -08:00
watchdog	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
xen	treewide: Switch DEFINE_TIMER callbacks to struct timer_list *	2017-11-21 15:57:05 -08:00
zorro
Kconfig
Makefile