kernel_optimize_test/arch/sh/include
Rich Felker bbe6c77857 sh: make sigcontext definition consistent across fpu/nofpu models
Up until now, the SH version of the sigcontext structure, and thus
mcontext_t/ucontext_t, varied depending on the cpu model the kernel
was built to run on. SH-4 (including SH-4A) and SH-2A used the form
with space for FPU registers, and everything else used a form that
omitted them.

From a userspace perspective, however, the structure layout must be
fixed for a given ABI. Traditionally glibc and uClibc used the form
with space for FPU registers only when __SH4__ (which implies FPU;
__SH4_NOFPU__ is the predefined macro for SH-4 but with no-FPU ABI)
was defined. As a result:

- SH-4 no-FPU programs never matched kernel sigcontext.

- SH-3 programs did not match kernel sigcontext if run on SH-4,
  despite an apparent intent that they be compatible.

- SH-2 and SH-2A programs (using uClibc) did not match kernel
  sigcontext if run on SH-2A.

The mismatch might seem inconsequential because it occurs at the end
of the sigcontext structure, but sigcontext is embedded as uc_mcontext
in ucontext_t, where it is followed by uc_sigmask, an important member
for signal handlers to have access to. In particular, access to
uc_sigmask is necessary for a correct implementation of thread
cancellation.

It would be possible to retain support for both sigcontext ABIs via a
personality mechanism, but since many configurations were already
broken and nobody noticed, and since there are very few if any users
of legacy no-FPU models anymore, I have opted to just remove the
variation and always include space for the FPU registers in
sigcontext. This was proposed and discussed on a thread "SH sigcontext
ABI is broken" cross-posted to linux-sh, libc-alpha, and musl libc
lists in June 2015, and no objections were raised.

Signed-off-by: Rich Felker <dalias@libc.org>
2016-07-31 03:33:32 +00:00
..
asm sh: cmpxchg: fix a bit shift bug in big_endian os 2016-07-31 03:33:32 +00:00
cpu-common/cpu
cpu-sh2/cpu
cpu-sh2a/cpu
cpu-sh3/cpu
cpu-sh4/cpu
cpu-sh4a/cpu
cpu-sh5/cpu
mach-common/mach gpio: Include linux/gpio.h instead of asm/gpio.h 2016-02-16 00:20:03 +01:00
mach-dreamcast/mach
mach-ecovec24/mach
mach-kfr2r09/mach
mach-landisk/mach
mach-migor/mach
mach-sdk7786/mach
mach-se/mach
mach-sh03/mach
mach-x3proto/mach
uapi/asm sh: make sigcontext definition consistent across fpu/nofpu models 2016-07-31 03:33:32 +00:00