Eric Dumazet 9f29f6f8da tcp: make sure treq->af_specific is initialized ... [ Upstream commit ba5a4fdd63ae0c575707030db0b634b160baddd7 ] syzbot complained about a recent change in TCP stack, hitting a NULL pointer [1] tcp request sockets have an af_specific pointer, which was used before the blamed change only for SYNACK generation in non SYNCOOKIE mode. tcp requests sockets momentarily created when third packet coming from client in SYNCOOKIE mode were not using treq->af_specific. Make sure this field is populated, in the same way normal TCP requests sockets do in tcp_conn_request(). [1] TCP: request_sock_TCPv6: Possible SYN flooding on port 20002. Sending cookies. Check SNMP counters. general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] CPU: 1 PID: 3695 Comm: syz-executor864 Not tainted 5.18.0-rc3-syzkaller-00224-g5fd1fe4807f9 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:tcp_create_openreq_child+0xe16/0x16b0 net/ipv4/tcp_minisocks.c:534 Code: 48 c1 ea 03 80 3c 02 00 0f 85 e5 07 00 00 4c 8b b3 28 01 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d 7e 08 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 c9 07 00 00 48 8b 3c 24 48 89 de 41 ff 56 08 48 RSP: 0018:ffffc90000de0588 EFLAGS: 00010202 RAX: dffffc0000000000 RBX: ffff888076490330 RCX: 0000000000000100 RDX: 0000000000000001 RSI: ffffffff87d67ff0 RDI: 0000000000000008 RBP: ffff88806ee1c7f8 R08: 0000000000000000 R09: 0000000000000000 R10: ffffffff87d67f00 R11: 0000000000000000 R12: ffff88806ee1bfc0 R13: ffff88801b0e0368 R14: 0000000000000000 R15: 0000000000000000 FS: 00007f517fe58700(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ffcead76960 CR3: 000000006f97b000 CR4: 00000000003506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <IRQ> tcp_v6_syn_recv_sock+0x199/0x23b0 net/ipv6/tcp_ipv6.c:1267 tcp_get_cookie_sock+0xc9/0x850 net/ipv4/syncookies.c:207 cookie_v6_check+0x15c3/0x2340 net/ipv6/syncookies.c:258 tcp_v6_cookie_check net/ipv6/tcp_ipv6.c:1131 [inline] tcp_v6_do_rcv+0x1148/0x13b0 net/ipv6/tcp_ipv6.c:1486 tcp_v6_rcv+0x3305/0x3840 net/ipv6/tcp_ipv6.c:1725 ip6_protocol_deliver_rcu+0x2e9/0x1900 net/ipv6/ip6_input.c:422 ip6_input_finish+0x14c/0x2c0 net/ipv6/ip6_input.c:464 NF_HOOK include/linux/netfilter.h:307 [inline] NF_HOOK include/linux/netfilter.h:301 [inline] ip6_input+0x9c/0xd0 net/ipv6/ip6_input.c:473 dst_input include/net/dst.h:461 [inline] ip6_rcv_finish net/ipv6/ip6_input.c:76 [inline] NF_HOOK include/linux/netfilter.h:307 [inline] NF_HOOK include/linux/netfilter.h:301 [inline] ipv6_rcv+0x27f/0x3b0 net/ipv6/ip6_input.c:297 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5405 __netif_receive_skb+0x24/0x1b0 net/core/dev.c:5519 process_backlog+0x3a0/0x7c0 net/core/dev.c:5847 __napi_poll+0xb3/0x6e0 net/core/dev.c:6413 napi_poll net/core/dev.c:6480 [inline] net_rx_action+0x8ec/0xc60 net/core/dev.c:6567 __do_softirq+0x29b/0x9c2 kernel/softirq.c:558 invoke_softirq kernel/softirq.c:432 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:637 irq_exit_rcu+0x5/0x20 kernel/softirq.c:649 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1097 Fixes: 5b0b9e4c2c89 ("tcp: md5: incorrect tcp_header_len for incoming connections") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Francesco Ruggeri <fruggeri@arista.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-05-09 09:05:04 +02:00
..
acpi	ACPICA: actypes.h: Expand the ACPI_ACCESS_ definitions	2022-01-27 10:54:18 +01:00
asm-generic	tlb: hugetlb: Add more sizes to tlb_remove_huge_tlb_entry	2022-04-20 09:23:22 +02:00
clocksource	clocksource/drivers/timer-ti-dm: Save and restore timer TIOCP_CFG	2021-07-14 16:56:12 +02:00
crypto	crypto: public_key: fix overflow during implicit conversion	2021-09-18 13:40:08 +02:00
drm	drm: protect drm_master pointers in drm_lease.c	2021-09-18 13:40:19 +02:00
dt-bindings	clk: imx8mq: remove SYS PLL 1/2 clock gates	2021-07-14 16:56:20 +02:00
keys	certs: Add EFI_CERT_X509_GUID support for dbx entries	2021-06-30 08:47:30 -04:00
kunit
kvm
linux	mtd: fix 'part' field data corruption in mtd_info	2022-05-09 09:05:02 +02:00
math-emu
media	media: subdev: disallow ioctl for saa6588/davinci	2021-07-19 09:45:02 +02:00
memory	memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual Mode	2022-05-09 09:05:02 +02:00
misc
net	tcp: make sure treq->af_specific is initialized	2022-05-09 09:05:04 +02:00
pcmcia
ras
rdma	RDMA/netlink: Add __maybe_unused to static inline in C file	2021-11-26 10:39:21 +01:00
scsi	scsi: iscsi: Fix conn cleanup and stop race during iscsid restart	2022-04-20 09:23:17 +02:00
soc	firmware: raspberrypi: Keep count of all consumers	2021-09-15 09:50:41 +02:00
sound	ALSA: pcm: Fix potential AB/BA lock with buffer_mutex and mmap_lock	2022-04-08 14:39:53 +02:00
target	scsi: target: Fix ordered tag handling	2021-11-26 10:39:11 +01:00
trace	SUNRPC: Fix the svc_deferred_event trace class	2022-04-20 09:23:11 +02:00
uapi	can: isotp: set default value for N_As to 50 micro seconds	2022-04-13 21:01:00 +02:00
vdso
video
xen	xen/gnttab: fix gnttab_end_foreign_access() without page specified	2022-03-11 12:11:54 +01:00