Guoqing Jiang 9e1b0211c5 dlm: recheck kthread_should_stop() before schedule() ... Call schedule() here could make the thread miss wake up from kthread_stop(), so it is better to recheck kthread_should_stop() before call schedule(), a symptom happened when I run indefinite test (which mostly created clustered raid1, assemble it in other nodes, then stop them) of clustered raid. $ ps aux|grep md|grep D root 4211 0.0 0.0 19760 2220 ? Ds 02:58 0:00 mdadm -Ssq $ cat /proc/4211/stack kthread_stop+0x4d/0x150 dlm_recoverd_stop+0x15/0x20 [dlm] dlm_release_lockspace+0x2ab/0x460 [dlm] leave+0xbf/0x150 [md_cluster] md_cluster_stop+0x18/0x30 [md_mod] bitmap_free+0x12e/0x140 [md_mod] bitmap_destroy+0x7f/0x90 [md_mod] __md_stop+0x21/0xa0 [md_mod] do_md_stop+0x15f/0x5c0 [md_mod] md_ioctl+0xa65/0x18a0 [md_mod] blkdev_ioctl+0x49e/0x8d0 block_ioctl+0x41/0x50 do_vfs_ioctl+0x96/0x5b0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x1e/0xad This maybe not resolve the issue completely since the KTHREAD_SHOULD_STOP flag could be set between "break" and "schedule", but at least the chance for the symptom happen could be reduce a lot (The indefinite test runs more than 20 hours without problem and it happens easily without the change). Signed-off-by: Guoqing Jiang <gqjiang@suse.com> Signed-off-by: David Teigland <teigland@redhat.com>		2017-09-25 12:48:10 -05:00
..
ast.c	DLM: fix overflow dlm_cb_seq	2017-09-25 12:45:21 -05:00
ast.h	dlm: use workqueue for callbacks	2011-07-15 12:30:43 -05:00
config.c	dlm: audit and remove any unnecessary uses of module.h	2016-10-19 11:00:03 -05:00
config.h	dlm: add log_info config option	2016-06-21 09:04:24 -05:00
debug_fs.c	dlm: Improve a size determination in table_seq_start()	2017-08-07 11:23:09 -05:00
dir.c	dlm: use INFO for recovery messages	2014-02-14 11:54:44 -06:00
dir.h	dlm: use rsbtbl as resource directory	2012-07-16 14:16:19 -05:00
dlm_internal.h	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
Kconfig	fs/dlm: remove CONFIG_EXPERIMENTAL	2012-11-01 15:27:24 -05:00
lock.c	DLM: fix conversion deadlock when DLM_LKF_NODLCKWT flag is set	2017-09-25 12:45:21 -05:00
lock.h	dlm: adopt orphan locks	2014-11-19 14:48:02 -06:00
lockspace.c	dlm: constify kset_uevent_ops structure	2017-08-07 11:23:09 -05:00
lockspace.h	dlm: detect available userspace daemon	2008-08-28 11:49:43 -05:00
lowcomms.c	DLM: fix NULL pointer dereference in send_to_sock()	2017-09-25 12:45:21 -05:00
lowcomms.h	dlm: fix deadlock between dlm_send and dlm_controld	2012-08-08 11:33:35 -05:00
lvb_table.h
main.c	dlm: audit and remove any unnecessary uses of module.h	2016-10-19 11:00:03 -05:00
Makefile
member.c	dlm: Delete an unnecessary variable initialisation in dlm_ls_start()	2017-08-07 11:23:09 -05:00
member.h	dlm: add recovery callbacks	2012-01-04 08:56:31 -06:00
memory.c	dlm: NULL dereference on failure in kmem_cache_create()	2012-05-15 10:39:28 -05:00
memory.h	dlm: improve rsb searches	2011-07-12 16:02:09 -05:00
midcomms.c	dlm: fix up memory allocation flags	2008-12-23 10:15:40 -06:00
midcomms.h
netlink.c	dlm for 4.10	2016-12-14 08:31:37 -08:00
plock.c	fs/locks: Remove fl_nspid and use fs-specific l_pid for remote locks	2017-07-16 10:28:22 -04:00
rcom.c	DLM: retry rcom when dlm_wait_function is timed out.	2017-09-25 12:45:21 -05:00
rcom.h	dlm: use rsbtbl as resource directory	2012-07-16 14:16:19 -05:00
recover.c	DLM: retry rcom when dlm_wait_function is timed out.	2017-09-25 12:45:21 -05:00
recover.h	dlm: use rsbtbl as resource directory	2012-07-16 14:16:19 -05:00
recoverd.c	dlm: recheck kthread_should_stop() before schedule()	2017-09-25 12:48:10 -05:00
recoverd.h	dlm: fix unlock balance warnings	2012-08-08 11:33:49 -05:00
requestqueue.c	dlm: fixes for nodir mode	2012-05-02 14:15:27 -05:00
requestqueue.h
user.c	dlm: avoid double-free on error path in dlm_device_{register,unregister}	2017-08-07 11:23:09 -05:00
user.h	dlm: record full callback state	2011-03-10 10:40:00 -06:00
util.c
util.h