kernel_optimize_test/net/decnet
Michal Kubecek ae0be8de9a netlink: make nla_nest_start() add NLA_F_NESTED flag
Even if the NLA_F_NESTED flag was introduced more than 11 years ago, most
netlink based interfaces (including recently added ones) are still not
setting it in kernel generated messages. Without the flag, message parsers
not aware of attribute semantics (e.g. wireshark dissector or libmnl's
mnl_nlmsg_fprintf()) cannot recognize nested attributes and won't display
the structure of their contents.

Unfortunately we cannot just add the flag everywhere as there may be
userspace applications which check nlattr::nla_type directly rather than
through a helper masking out the flags. Therefore the patch renames
nla_nest_start() to nla_nest_start_noflag() and introduces nla_nest_start()
as a wrapper adding NLA_F_NESTED. The calls which add NLA_F_NESTED manually
are rewritten to use nla_nest_start().

Except for changes in include/net/netlink.h, the patch was generated using
this semantic patch:

@@ expression E1, E2; @@
-nla_nest_start(E1, E2)
+nla_nest_start_noflag(E1, E2)

@@ expression E1, E2; @@
-nla_nest_start_noflag(E1, E2 | NLA_F_NESTED)
+nla_nest_start(E1, E2)

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-04-27 17:03:44 -04:00
..
netfilter decnet: whitespace fixes 2018-07-24 14:10:42 -07:00
af_decnet.c net: use rcu_dereference_protected to fetch sk_dst_cache in sk_destruct 2019-04-01 18:10:51 -07:00
dn_dev.c decnet: fix DN_IFREQ_SIZE 2019-01-27 23:11:55 -08:00
dn_fib.c net: Rename net/nexthop.h net/rtnh.h 2019-04-22 21:47:25 -07:00
dn_neigh.c proc: introduce proc_create_net{,_data} 2018-05-16 07:24:30 +02:00
dn_nsp_in.c decnet: whitespace fixes 2018-07-24 14:10:42 -07:00
dn_nsp_out.c decnet: whitespace fixes 2018-07-24 14:10:42 -07:00
dn_route.c mm: convert totalram_pages and totalhigh_pages variables to atomic 2018-12-28 12:11:47 -08:00
dn_rules.c decnet: whitespace fixes 2018-07-24 14:10:42 -07:00
dn_table.c netlink: make nla_nest_start() add NLA_F_NESTED flag 2019-04-27 17:03:44 -04:00
dn_timer.c
Kconfig decnet: whitespace fixes 2018-07-24 14:10:42 -07:00
Makefile decnet: whitespace fixes 2018-07-24 14:10:42 -07:00
README
sysctl_net_decnet.c
TODO decnet: whitespace fixes 2018-07-24 14:10:42 -07:00

                       Linux DECnet Project
                      ======================

The documentation for this kernel subsystem is available in the
Documentation/networking subdirectory of this distribution and also
on line at http://www.chygwyn.com/DECnet/

Steve Whitehouse <SteveW@ACM.org>