kernel_optimize_test/drivers/net/mlx4
Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
alloc.c mlx4_core: Add HW queues allocation helpers 2008-04-25 14:27:08 -07:00
catas.c mlx4_core: Fix confusion between mlx4_event and mlx4_dev_event enums 2008-04-16 21:01:08 -07:00
cmd.c mlx4_core: Move opening brace of function onto a new line 2008-04-16 21:01:04 -07:00
cq.c mlx4_core: Add a way to set the "collapsed" CQ flag 2008-04-29 13:46:50 -07:00
eq.c PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures 2008-07-24 10:47:21 -07:00
fw.c mlx4_core: Use MOD_STAT_CFG command to get minimal page size 2008-07-14 23:48:53 -07:00
fw.h mlx4_core: Use MOD_STAT_CFG command to get minimal page size 2008-07-14 23:48:53 -07:00
icm.c SG: Change sg_set_page() to take length and offset argument 2007-10-24 11:20:47 +02:00
icm.h mlx4_core: Write MTTs from CPU instead with of WRITE_MTT FW command 2007-10-09 19:59:16 -07:00
intf.c mlx4_core: Fix confusion between mlx4_event and mlx4_dev_event enums 2008-04-16 21:01:08 -07:00
main.c mlx4_core: Use MOD_STAT_CFG command to get minimal page size 2008-07-14 23:48:53 -07:00
Makefile IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters 2007-05-08 18:00:38 -07:00
mcg.c IB/mlx4: Add support for blocking multicast loopback packets 2008-07-14 23:48:48 -07:00
mlx4.h mlx4_core: Move kernel doorbell management into core 2008-04-23 11:55:45 -07:00
mr.c mlx4_core: Support creation of FMRs with pages smaller than 4K 2008-05-05 15:56:52 -07:00
pd.c mlx4_core: Fix section mismatches 2007-10-10 15:43:54 -07:00
profile.c IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters 2007-05-08 18:00:38 -07:00
qp.c mlx4_core: Add helper to move QP to ready-to-send 2008-04-25 14:52:32 -07:00
reset.c mlx4_core: Wait 1 second after reset before accessing device 2007-08-13 08:47:44 -07:00
srq.c mlx4_core: Fix section mismatches 2007-10-10 15:43:54 -07:00