Namhyung Kim 25dd9171f5 perf probe: Fix probing kretprobes ... The commit dfef99cd0b ("perf probe: Use ref_reloc_sym based address instead of the symbol name") converts kprobes to use ref_reloc_sym (i.e. _stext) and offset instead of using symbol's name directly. So on my system, adding do_fork ends up with like below: $ sudo perf probe -v --add do_fork%return probe-definition(0): do_fork%return symbol:do_fork file:(null) line:0 offset:0 return:1 lazy:(null) 0 arguments Looking at the vmlinux_path (7 entries long) Using /lib/modules/3.17.6-1-ARCH/build/vmlinux for symbols Could not open debuginfo. Try to use symbols. Opening /sys/kernel/debug/tracing/kprobe_events write=1 Added new event: Writing event: r:probe/do_fork _stext+456136 Failed to write event: Invalid argument Error: Failed to add events. Reason: Operation not permitted (Code: -1) As you can see, the do_fork was translated to _stext+456136. This was because to support (local) symbols that have same name. But the problem is that kretprobe requires to be inserted at function start point so it simply checks whether it's called with offset 0. And if not, it'll return with -EINVAL. You can see it with dmesg. $ dmesg | tail -1 [125621.764103] Return probe must be used without offset. So we need to use the symbol name instead of ref_reloc_sym in case of return probes. Reported-by: Jiri Olsa <jolsa@redhat.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> Tested-by: Jiri Olsa <jolsa@redhat.com> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: David Ahern <dsahern@gmail.com> Link: http://lkml.kernel.org/r/1421234288-22758-4-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>		2015-01-21 10:06:24 -03:00
..
arch	perf tools powerpc: Use dwfl_report_elf() instead of offline.	2015-01-16 17:49:30 -03:00
bench	perf tools: Avoid build splat for syscall numbers with uclibc	2015-01-16 17:49:29 -03:00
config	perf tools: Fix building error in x86_64 when dwarf unwind is on	2015-01-16 17:49:28 -03:00
Documentation
python
scripts	perf scripting perl: Force to use stdbool	2015-01-21 10:05:00 -03:00
tests	perf test: Fix dwarf unwind using libunwind.	2015-01-16 17:49:29 -03:00
ui	perf hists browser: Fix segfault when showing callchain	2015-01-08 11:59:16 -03:00
util	perf probe: Fix probing kretprobes	2015-01-21 10:06:24 -03:00
.gitignore
builtin-annotate.c
builtin-bench.c
builtin-buildid-cache.c
builtin-buildid-list.c
builtin-diff.c
builtin-evlist.c
builtin-help.c
builtin-inject.c
builtin-kmem.c
builtin-kvm.c
builtin-list.c
builtin-lock.c
builtin-mem.c
builtin-probe.c
builtin-record.c
builtin-report.c
builtin-sched.c
builtin-script.c
builtin-stat.c
builtin-timechart.c
builtin-top.c	perf tools: Avoid build splat for syscall numbers with uclibc	2015-01-16 17:49:29 -03:00
builtin-trace.c
builtin.h
command-list.txt
CREDITS
design.txt
Makefile
Makefile.perf	tools: Remove bitops/hweight usage of bits in tools/perf	2015-01-16 17:49:29 -03:00
MANIFEST	tools: Remove bitops/hweight usage of bits in tools/perf	2015-01-16 17:49:29 -03:00
perf-archive.sh
perf-completion.sh
perf-read-vdso.c
perf-sys.h	perf tools: Avoid build splat for syscall numbers with uclibc	2015-01-16 17:49:29 -03:00
perf-with-kcore.sh
perf.c
perf.h