Mihai Moldovan cc1956f8b2 kconfig: nconf: stop endless search loops ... [ Upstream commit 8c94b430b9f6213dec84e309bb480a71778c4213 ] If the user selects the very first entry in a page and performs a search-up operation, or selects the very last entry in a page and performs a search-down operation that will not succeed (e.g., via [/]asdfzzz[Up Arrow]), nconf will never terminate searching the page. The reason is that in this case, the starting point will be set to -1 or n, which is then translated into (n - 1) (i.e., the last entry of the page) or 0 (i.e., the first entry of the page) and finally the search begins. This continues to work fine until the index reaches 0 or (n - 1), at which point it will be decremented to -1 or incremented to n, but not checked against the starting point right away. Instead, it's wrapped around to the bottom or top again, after which the starting point check occurs... and naturally fails. My original implementation added another check for -1 before wrapping the running index variable around, but Masahiro Yamada pointed out that the actual issue is that the comparison point (starting point) exceeds bounds (i.e., the [0,n-1] interval) in the first place and that, instead, the starting point should be fixed. This has the welcome side-effect of also fixing the case where the starting point was n while searching down, which also lead to an infinite loop. OTOH, this code is now essentially all his work. Amazingly, nobody seems to have been hit by this for 11 years - or at the very least nobody bothered to debug and fix this. Signed-off-by: Mihai Moldovan <ionic@ionic.de> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2021-05-19 10:12:56 +02:00
..
atomic	Merge branch 'kcsan' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu into locking/core	2020-10-09 08:56:02 +02:00
basic	kbuild: introduce hostprogs-always-y and userprogs-always-y	2020-08-10 01:32:59 +09:00
clang-tools	Makefile: Add clang-tidy and static analyzer support to makefile	2020-08-27 00:44:33 +09:00
coccinelle	Merge branch 'for-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux	2020-10-18 14:20:35 -07:00
dtc	scripts/dtc: Update to upstream version v1.6.0-31-gcbca977ea121	2020-10-12 09:58:15 -05:00
dummy-tools	kbuild: dummy-tools: fix inverted tests for gcc	2021-03-30 14:31:50 +02:00
gcc-plugins	Kbuild updates for v5.9	2020-08-09 14:10:26 -07:00
gdb	scripts/gdb/tasks: add headers and improve spacing format	2020-10-16 11:11:22 -07:00
genksyms	genksyms: keywords: Use __restrict not _restrict	2020-08-18 20:16:46 +09:00
kconfig	kconfig: nconf: stop endless search loops	2021-05-19 10:12:56 +02:00
ksymoops
mod	treewide: Convert macro and uses of __section(foo) to __section("foo")	2020-10-25 14:51:49 -07:00
package	builddeb: Fix rootless build in setuid/setgid directory	2020-11-02 11:31:00 +09:00
selinux	scripts/selinux,selinux: update mdp to enable policy capabilities	2020-08-17 20:42:00 -04:00
tracing	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166	2019-05-30 11:26:39 -07:00
.gitignore	kbuild: preprocess module linker script	2020-09-25 00:36:41 +09:00
adjust_autoksyms.sh	kbuild: split adjust_autoksyms.sh in two parts	2020-03-03 20:49:21 +09:00
asn1_compiler.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36	2019-05-24 17:27:11 +02:00
bin2c.c
bloat-o-meter	scripts/bloat-o-meter: Support comparing library archives	2020-08-07 11:33:21 -07:00
bootgraph.pl	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 391	2019-06-05 17:37:11 +02:00
bpf_helpers_doc.py	bpf: Add struct bpf_redir_neigh forward declaration to BPF helper defs	2020-10-29 15:19:04 +01:00
cc-can-link.sh
check_extable.sh
check-sysctl-docs	docs: add a script to check sysctl docs	2020-02-25 03:35:16 -07:00
checkincludes.pl
checkkconfigsymbols.py	kconfig: remove '---help---' support	2020-08-14 13:30:03 +09:00
checkpatch.pl	checkpatch: fix unescaped left brace	2020-12-30 11:53:56 +01:00
checkstack.pl	scripts/checkstack.pl: fix arm sp regex	2020-05-26 00:03:16 +09:00
checksyscalls.sh
checkversion.pl
clang-version.sh
cleanfile
cleanpatch
coccicheck	scripts: coccicheck: Change default condition for parallelism	2020-10-12 10:37:56 +02:00
config	scripts/config: allow colons in option strings for sed	2020-04-23 01:10:16 +09:00
const_structs.checkpatch	const_structs.checkpatch: add pinctrl_ops and pinmux_ops	2020-10-16 11:11:21 -07:00
decode_stacktrace.sh	scripts/decode_stacktrace.sh: guess path to vmlinux by release name	2020-08-07 11:33:21 -07:00
decodecode	scripts/decodecode: add the capability to supply the program counter	2020-10-13 18:38:26 -07:00
depmod.sh	depmod: handle the case of /sbin/depmod without /sbin in PATH	2021-01-12 20:18:16 +01:00
dev-needs.sh	scripts/dev-needs: Add script to list device dependencies	2020-09-04 18:19:37 +02:00
diffconfig
documentation-file-ref-check	scripts: documentation-file-ref-check: Add line break before exit	2020-04-15 15:13:13 -06:00
export_report.pl	modpost: move the namespace field in Module.symvers last	2020-03-17 08:59:03 +09:00
extract_xc3028.pl	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 339	2019-06-05 17:37:07 +02:00
extract-cert.c	extract-cert: add static to local data	2020-08-18 20:16:46 +09:00
extract-ikconfig
extract-module-sig.pl
extract-sys-certs.pl
extract-vmlinux	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 378	2019-06-05 17:37:10 +02:00
faddr2line
file-size.sh
find-unused-docs.sh	scripts/find-unused-docs: Fix massive false positives	2020-01-27 14:25:06 -07:00
gcc-goto.sh
gcc-ld
gcc-plugin.sh	gcc-plugins: drop support for GCC <= 4.7	2020-04-09 00:13:45 +09:00
gcc-version.sh
gcc-x86_32-has-stack-protector.sh
gcc-x86_64-has-stack-protector.sh
gen_autoksyms.sh	kbuild: fix CONFIG_TRIM_UNUSED_KSYMS build for ppc64	2021-02-26 10:13:01 +01:00
gen_ksymdeps.sh
get_abi.pl	scripts: get_api.pl: Add sub-titles to ABI output	2020-11-02 13:45:37 +01:00
get_dvb_firmware	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
get_maintainer.pl	get_maintainer: exclude MAINTAINERS file(s) from --git-fallback	2020-10-16 11:11:19 -07:00
gfp-translate	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166	2019-05-30 11:26:39 -07:00
headerdep.pl
headers_check.pl
headers_install.sh	Merge branch 'work.fdpic' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2020-08-07 13:29:39 -07:00
insert-sys-cert.c
jobserver-exec	docs, parallelism: Rearrange how jobserver reservations are made	2019-11-22 10:35:18 -07:00
kallsyms.c	kallsyms: fix nonconverging kallsyms table with lld	2021-02-17 11:02:24 +01:00
Kbuild.include	kbuild: remove leftover comment for filechk utility	2020-10-21 00:28:53 +09:00
Kconfig.include	kconfig: unify cc-option and as-option	2020-06-17 10:38:42 +09:00
kernel-doc	scripts: kernel-doc: fix parsing function-like typedefs	2020-12-30 11:53:33 +01:00
ld-version.sh
leaking_addresses.pl	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166	2019-05-30 11:26:39 -07:00
Lindent
link-vmlinux.sh	Kbuild updates for v5.10	2020-10-22 13:13:57 -07:00
lld-version.sh	kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1	2020-12-01 22:46:06 +09:00
Makefile	scripts: set proper OpenSSL include dir also for sign-file	2021-02-17 11:02:28 +01:00
Makefile.asm-generic
Makefile.build	kbuild: avoid split lines in .mod files	2020-12-06 21:09:28 +09:00
Makefile.clean	kbuild: introduce hostprogs-always-y and userprogs-always-y	2020-08-10 01:32:59 +09:00
Makefile.dtbinst	kbuild: refactor Makefile.dtbinst more	2020-03-25 10:19:43 +09:00
Makefile.extrawarn	Makefile.extrawarn: move -Wcast-align to W=3	2020-11-25 03:36:10 +09:00
Makefile.gcc-plugins	gcc-plugins/stackleak: Use asm instrumentation to avoid useless register saving	2020-06-24 07:48:28 -07:00
Makefile.headersinst	kbuild: move headers_check rule to usr/include/Makefile	2019-11-15 00:23:10 +09:00
Makefile.host	kbuild: sort hostprogs before passing it to ifneq	2020-08-10 01:32:59 +09:00
Makefile.kasan	kasan: fix hwasan build for gcc	2021-04-28 13:40:02 +02:00
Makefile.kcov	kbuild: include scripts/Makefile.* only when relevant CONFIG is enabled	2020-08-10 01:32:59 +09:00
Makefile.kcsan	Kbuild updates for v5.10	2020-10-22 13:13:57 -07:00
Makefile.lib	dt-bindings: Use json for processed-schema*	2020-08-19 14:31:57 -06:00
Makefile.modfinal	kbuild: preprocess module linker script	2020-09-25 00:36:41 +09:00
Makefile.modinst	kbuild: modinst: read modules.order instead of $(MODVERDIR)/*.mod	2019-07-17 22:39:27 +09:00
Makefile.modpost	kbuild: remove redundant FORCE definition in scripts/Makefile.modpost	2020-08-02 23:09:16 +09:00
Makefile.modsign	kbuild: modsign: read modules.order instead of $(MODVERDIR)/*.mod	2019-07-17 22:39:27 +09:00
Makefile.package	kbuild: fix broken builds because of GZIP,BZIP2,LZOP variables	2020-06-11 20:14:41 +09:00
Makefile.ubsan	Kbuild updates for v5.10	2020-10-22 13:13:57 -07:00
Makefile.userprogs	kbuild: add infrastructure to build userspace programs	2020-05-17 18:52:01 +09:00
makelst
markup_oops.pl	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 373	2019-06-05 17:37:10 +02:00
mkcompile_h	kbuild: Use uname for LINUX_COMPILE_HOST detection	2020-10-21 00:46:04 +09:00
mkmakefile	kbuild: get rid of $(realpath ...) from scripts/mkmakefile	2019-08-29 23:54:29 +09:00
mksysmap	mksysmap: Fix the mismatch of '.L' symbols in System.map	2020-06-06 23:39:20 +09:00
mkuboot.sh
module.lds.S	kbuild: preprocess module linker script	2020-09-25 00:36:41 +09:00
modules-check.sh	kbuild: make module name conflict fatal error	2020-05-26 00:03:16 +09:00
nsdeps	scripts: add dummy report mode to add_namespace.cocci	2020-07-10 14:19:58 +02:00
objdiff	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 199	2019-05-30 11:29:23 -07:00
parse-maintainers.pl	parse-maintainers: Do not sort section content by default	2020-03-26 15:08:27 -07:00
patch-kernel
profile2linkerlist.pl
prune-kernel
recordmcount.c	ftrace: Have recordmcount use w8 to read relp->r_info in arm64_is_fake_mcount	2021-03-09 11:11:14 +01:00
recordmcount.h	recordmcount: support >64k sections	2020-06-16 21:21:00 -04:00
recordmcount.pl	scripts/recordmcount.pl: support big endian for ARCH sh	2021-02-26 10:13:02 +01:00
setlocalversion	scripts/setlocalversion: make git describe output more reliable	2020-09-25 02:28:12 +09:00
show_delta	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 438	2019-06-05 17:37:17 +02:00
sign-file.c
sorttable.c	s390/kernel: expand exception table logic to allow new handling options	2020-07-20 10:55:50 +02:00
sorttable.h	scripts/sorttable: Implement build-time ORC unwind table sorting	2019-12-13 10:47:58 +01:00
spdxcheck-test.sh
spdxcheck.py	scripts/spdxcheck.py: handle license identifiers in XML comments	2020-10-02 11:31:26 +02:00
spelling.txt	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2020-10-15 15:11:56 -07:00
sphinx-pre-install	docs: Don't push Sphinx upgrades quite so readily	2020-06-26 09:31:53 -06:00
split-man.pl
stackdelta
stackusage
subarch.include
tags.sh	Merge branch 'locking/urgent' into locking/core, to pick up fixes	2020-10-09 08:55:17 +02:00
tools-support-relr.sh	scripts/tools-support-relr.sh: un-quote variables	2019-11-13 10:52:05 +00:00
unifdef.c
ver_linux	ver_linux: Query ld cache for versions of libc/libcpp run-time	2020-02-10 13:35:15 -08:00
xen-hypercalls.sh
xz_wrap.sh	kbuild: add variables for compression tools	2020-06-06 23:42:01 +09:00