Baochen Qiang 9b0d1f4cb8 bus: mhi: Wait for M2 state during system resume ... commit 02b49cd1174527e611768fc2ce0f75a74dfec7ae upstream. During system resume, MHI host triggers M3->M0 transition and then waits for target device to enter M0 state. Once done, the device queues a state change event into ctrl event ring and notifies MHI host by raising an interrupt, where a tasklet is scheduled to process this event. In most cases, the tasklet is served timely and wait operation succeeds. However, there are cases where CPU is busy and cannot serve this tasklet for some time. Once delay goes long enough, the device moves itself to M1 state and also interrupts MHI host after inserting a new state change event to ctrl ring. Later when CPU finally has time to process the ring, there will be two events: 1. For M3->M0 event, which is the first event to be processed queued first. The tasklet handler serves the event, updates device state to M0 and wakes up the task. 2. For M0->M1 event, which is processed later, the tasklet handler triggers M1->M2 transition and updates device state to M2 directly, then wakes up the MHI host (if it is still sleeping on this wait queue). Note that although MHI host has been woken up while processing the first event, it may still has no chance to run before the second event is processed. In other words, MHI host has to keep waiting till timeout causing the M0 state to be missed. kernel log here: ... Apr 15 01:45:14 test-NUC8i7HVK kernel: [ 4247.911251] mhi 0000:06:00.0: Entered with PM state: M3, MHI state: M3 Apr 15 01:45:14 test-NUC8i7HVK kernel: [ 4247.917762] mhi 0000:06:00.0: State change event to state: M0 Apr 15 01:45:14 test-NUC8i7HVK kernel: [ 4247.917767] mhi 0000:06:00.0: State change event to state: M1 Apr 15 01:45:14 test-NUC8i7HVK kernel: [ 4338.788231] mhi 0000:06:00.0: Did not enter M0 state, MHI state: M2, PM state: M2 ... Fix this issue by simply adding M2 as a valid state for resume. Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 Cc: stable@vger.kernel.org Fixes: 0c6b20a1d7 ("bus: mhi: core: Add support for MHI suspend and resume") Signed-off-by: Baochen Qiang <bqiang@codeaurora.org> Reviewed-by: Hemant Kumar <hemantk@codeaurora.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Link: https://lore.kernel.org/r/20210524040312.14409-1-bqiang@codeaurora.org [mani: slightly massaged the commit message] Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Link: https://lore.kernel.org/r/20210621161616.77524-4-manivannan.sadhasivam@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-07-14 16:55:42 +02:00
..
fsl-mc	bus: fsl-mc: fix error return code in fsl_mc_object_allocate()	2020-12-30 11:53:46 +01:00
mhi	bus: mhi: Wait for M2 state during system resume	2021-07-14 16:55:42 +02:00
arm-cci.c
arm-integrator-lm.c
brcmstb_gisb.c	bus: brcmstb_gisb: Add support for breakpoint interrupts	2020-09-06 20:10:44 -07:00
bt1-apb.c
bt1-axi.c
da8xx-mstpri.c
hisi_lpc.c
imx-weim.c
Kconfig
Makefile
mips_cdmm.c	mips: cdmm: fix use-after-free in mips_cdmm_bus_discover	2020-12-30 11:53:24 +01:00
moxtet.c
mvebu-mbus.c	arch, drivers: replace for_each_membock() with for_each_mem_range()	2020-10-13 18:38:35 -07:00
omap_l3_noc.c	bus: omap_l3_noc: mark l3 irqs as IRQF_NO_THREAD	2021-03-30 14:31:56 +02:00
omap_l3_noc.h
omap_l3_smx.c
omap_l3_smx.h
omap-ocp2scp.c
qcom-ebi2.c	bus: qcom: Put child node before return	2021-05-14 09:50:13 +02:00
simple-pm-bus.c
sun50i-de2.c
sunxi-rsb.c
tegra-aconnect.c
tegra-gmi.c
ti-pwmss.c
ti-sysc.c	bus: ti-sysc: Fix flakey idling of uarts and stop using swsup_sidle_act	2021-06-10 13:39:22 +02:00
ts-nbus.c
uniphier-system-bus.c
vexpress-config.c