forked from luck/tmp_suning_uos_patched
dec6aa49ab
This patch solve below report from Guennadi 1) > +/* Audio source select */ > +#define HDMI_SRC_MASK (0xF << 0) > +#define HDMI_SRC_I2S (0 << 0) /* default */ > +#define HDMI_SRC_SPDIF (1 << 0) > +#define HDMI_SRC_DSD (2 << 0) > +#define HDMI_SRC_HBR (3 << 0) I would be more specific with these macro names, i.e., include "AUDIO" or "SND" or something similar in them, e.g., HDMI_AUDIO_SRC_I2S. 2) > + case HDMI_SRC_I2S: > + data = (0x0 << 3); > + break; > + case HDMI_SRC_SPDIF: > + data = (0x1 << 3); > + break; > + case HDMI_SRC_DSD: > + data = (0x2 << 3); > + break; > + case HDMI_SRC_HBR: > + data = (0x3 << 3); In all above cases parenthesis are superfluous. Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
39 lines
846 B
C
39 lines
846 B
C
/*
|
|
* SH-Mobile High-Definition Multimedia Interface (HDMI)
|
|
*
|
|
* Copyright (C) 2010, Guennadi Liakhovetski <g.liakhovetski@gmx.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#ifndef SH_MOBILE_HDMI_H
|
|
#define SH_MOBILE_HDMI_H
|
|
|
|
struct sh_mobile_lcdc_chan_cfg;
|
|
struct device;
|
|
|
|
/*
|
|
* flags format
|
|
*
|
|
* 0x0000000A
|
|
*
|
|
* A: Audio source select
|
|
*/
|
|
|
|
/* Audio source select */
|
|
#define HDMI_SND_SRC_MASK (0xF << 0)
|
|
#define HDMI_SND_SRC_I2S (0 << 0) /* default */
|
|
#define HDMI_SND_SRC_SPDIF (1 << 0)
|
|
#define HDMI_SND_SRC_DSD (2 << 0)
|
|
#define HDMI_SND_SRC_HBR (3 << 0)
|
|
|
|
struct sh_mobile_hdmi_info {
|
|
struct sh_mobile_lcdc_chan_cfg *lcd_chan;
|
|
struct device *lcd_dev;
|
|
unsigned int flags;
|
|
};
|
|
|
|
#endif
|