YueHaibing 89189557b4 fs/proc/proc_sysctl.c: Fix a NULL pointer dereference ... Syzkaller report this: sysctl could not get directory: /net//bridge -12 kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: 0000 [#1] SMP KASAN PTI CPU: 1 PID: 7027 Comm: syz-executor.0 Tainted: G C 5.1.0-rc3+ #8 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 RIP: 0010:__write_once_size include/linux/compiler.h:220 [inline] RIP: 0010:__rb_change_child include/linux/rbtree_augmented.h:144 [inline] RIP: 0010:__rb_erase_augmented include/linux/rbtree_augmented.h:186 [inline] RIP: 0010:rb_erase+0x5f4/0x19f0 lib/rbtree.c:459 Code: 00 0f 85 60 13 00 00 48 89 1a 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 48 89 f2 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 75 0c 00 00 4d 85 ed 4c 89 2e 74 ce 4c 89 ea 48 RSP: 0018:ffff8881bb507778 EFLAGS: 00010206 RAX: dffffc0000000000 RBX: ffff8881f224b5b8 RCX: ffffffff818f3f6a RDX: 000000000000000a RSI: 0000000000000050 RDI: ffff8881f224b568 RBP: 0000000000000000 R08: ffffed10376a0ef4 R09: ffffed10376a0ef4 R10: 0000000000000001 R11: ffffed10376a0ef4 R12: ffff8881f224b558 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 FS: 00007f3e7ce13700(0000) GS:ffff8881f7300000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fd60fbe9398 CR3: 00000001cb55c001 CR4: 00000000007606e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 PKRU: 55555554 Call Trace: erase_entry fs/proc/proc_sysctl.c:178 [inline] erase_header+0xe3/0x160 fs/proc/proc_sysctl.c:207 start_unregistering fs/proc/proc_sysctl.c:331 [inline] drop_sysctl_table+0x558/0x880 fs/proc/proc_sysctl.c:1631 get_subdir fs/proc/proc_sysctl.c:1022 [inline] __register_sysctl_table+0xd65/0x1090 fs/proc/proc_sysctl.c:1335 br_netfilter_init+0x68/0x1000 [br_netfilter] do_one_initcall+0xbc/0x47d init/main.c:901 do_init_module+0x1b5/0x547 kernel/module.c:3456 load_module+0x6405/0x8c10 kernel/module.c:3804 __do_sys_finit_module+0x162/0x190 kernel/module.c:3898 do_syscall_64+0x9f/0x450 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe Modules linked in: br_netfilter(+) backlight comedi(C) hid_sensor_hub max3100 ti_ads8688 udc_core fddi snd_mona leds_gpio rc_streamzap mtd pata_netcell nf_log_common rc_winfast udp_tunnel snd_usbmidi_lib snd_usb_toneport snd_usb_line6 snd_rawmidi snd_seq_device snd_hwdep videobuf2_v4l2 videobuf2_common videodev media videobuf2_vmalloc videobuf2_memops rc_gadmei_rm008z 8250_of smm665 hid_tmff hid_saitek hwmon_vid rc_ati_tv_wonder_hd_600 rc_core pata_pdc202xx_old dn_rtmsg as3722 ad714x_i2c ad714x snd_soc_cs4265 hid_kensington panel_ilitek_ili9322 drm drm_panel_orientation_quirks ipack cdc_phonet usbcore phonet hid_jabra hid extcon_arizona can_dev industrialio_triggered_buffer kfifo_buf industrialio adm1031 i2c_mux_ltc4306 i2c_mux ipmi_msghandler mlxsw_core snd_soc_cs35l34 snd_soc_core snd_pcm_dmaengine snd_pcm snd_timer ac97_bus snd_compress snd soundcore gpio_da9055 uio ecdh_generic mdio_thunder of_mdio fixed_phy libphy mdio_cavium iptable_security iptable_raw iptable_mangle iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 iptable_filter bpfilter ip6_vti ip_vti ip_gre ipip sit tunnel4 ip_tunnel hsr veth netdevsim vxcan batman_adv cfg80211 rfkill chnl_net caif nlmon dummy team bonding vcan bridge stp llc ip6_gre gre ip6_tunnel tunnel6 tun joydev mousedev ppdev tpm kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel aesni_intel ide_pci_generic piix aes_x86_64 crypto_simd cryptd ide_core glue_helper input_leds psmouse intel_agp intel_gtt serio_raw ata_generic i2c_piix4 agpgart pata_acpi parport_pc parport floppy rtc_cmos sch_fq_codel ip_tables x_tables sha1_ssse3 sha1_generic ipv6 [last unloaded: br_netfilter] Dumping ftrace buffer: (ftrace buffer empty) ---[ end trace 68741688d5fbfe85 ]--- commit 23da958803 ("fs/proc/proc_sysctl.c: fix NULL pointer dereference in put_links") forgot to handle start_unregistering() case, while header->parent is NULL, it calls erase_header() and as seen in the above syzkaller call trace, accessing &header->parent->root will trigger a NULL pointer dereference. As that commit explained, there is also no need to call start_unregistering() if header->parent is NULL. Link: http://lkml.kernel.org/r/20190409153622.28112-1-yuehaibing@huawei.com Fixes: 23da958803 ("fs/proc/proc_sysctl.c: fix NULL pointer dereference in put_links") Fixes: 0e47c99d7f ("sysctl: Replace root_list with links between sysctl_table_sets") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reported-by: Hulk Robot <hulkci@huawei.com> Reviewed-by: Kees Cook <keescook@chromium.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: Alexey Dobriyan <adobriyan@gmail.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2019-04-26 09:18:05 -07:00
..
array.c	proc: use seq_puts() everywhere	2019-03-05 21:07:22 -08:00
base.c	ptrace: Remove maxargs from task_current_syscall()	2019-04-04 09:17:15 -04:00
cmdline.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
consoles.c	proc: introduce proc_create_seq{,_data}	2018-05-16 07:23:35 +02:00
cpuinfo.c	x86 / CPU: Always show current CPU frequency in /proc/cpuinfo	2017-11-15 19:46:50 +01:00
devices.c	proc: introduce proc_create_seq{,_data}	2018-05-16 07:23:35 +02:00
fd.c	proc: use "unsigned int" in proc_fill_cache()	2018-06-07 17:34:38 -07:00
fd.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
generic.c	proc: fix /proc/net/* after setns(2)	2019-02-01 15:46:22 -08:00
inode.c	proc: Add fs_context support to procfs	2019-02-28 03:29:28 -05:00
internal.h	Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-03-12 14:08:19 -07:00
interrupts.c	proc: introduce proc_create_seq{,_data}	2018-05-16 07:23:35 +02:00
Kconfig	proc/kcore: add vmcoreinfo note to /proc/kcore	2018-08-22 10:52:46 -07:00
kcore.c	fs/proc/kcore.c: make kcore_modules static	2019-03-29 10:01:37 -07:00
kmsg.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
loadavg.c	sched: loadavg: consolidate LOAD_INT, LOAD_FRAC, CALC_LOAD	2018-10-26 16:26:32 -07:00
Makefile	proc: : uninline name_to_int()	2017-11-17 16:10:00 -08:00
meminfo.c	mm, proc: add KReclaimable to /proc/meminfo	2018-10-26 16:26:32 -07:00
namespaces.c	procfs: switch instantiate_t to d_splice_alias()	2018-05-26 14:20:50 -04:00
nommu.c	proc: introduce proc_create_seq{,_data}	2018-05-16 07:23:35 +02:00
page.c	mm: convert PG_balloon to PG_offline	2019-03-05 21:07:14 -08:00
proc_net.c	proc: fix /proc/net/* after setns(2)	2019-02-01 15:46:22 -08:00
proc_sysctl.c	fs/proc/proc_sysctl.c: Fix a NULL pointer dereference	2019-04-26 09:18:05 -07:00
proc_tty.c	tty: replace ->proc_fops with ->proc_show	2018-05-16 07:24:30 +02:00
root.c	Merge branch 'work.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-03-12 14:08:19 -07:00
self.c	fs/proc/self.c: code cleanup for proc_setup_self()	2019-03-05 21:07:21 -08:00
softirqs.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
stat.c	Merge branch 'akpm' (patches from Andrew)	2019-03-06 10:31:36 -08:00
task_mmu.c	coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping	2019-04-19 09:46:05 -07:00
task_nommu.c	Merge branch 'akpm' (patches from Andrew)	2019-03-06 10:31:36 -08:00
thread_self.c	fs/proc/thread_self.c: code cleanup for proc_setup_thread_self()	2019-03-05 21:07:21 -08:00
uptime.c	fs/proc/uptime.c: use ktime_get_boottime_ts64	2018-08-22 10:52:45 -07:00
util.c	fs/proc/util.c: include fs/proc/internal.h for name_to_int()	2019-01-04 13:13:45 -08:00
version.c	proc: introduce proc_create_single{,_data}	2018-05-16 07:23:35 +02:00
vmcore.c	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00