kernel_optimize_test/tools/bpf/bpftool
Jakub Kicinski dde7011a82 tools: bpftool: fix potential NULL pointer dereference in do_load
This patch fixes a possible null pointer dereference in
do_load, detected by the semantic patch deref_null.cocci,
with the following warning:

./tools/bpf/bpftool/prog.c:1021:23-25: ERROR: map_replace is NULL but dereferenced.

The following code has potential null pointer references:
881             map_replace = reallocarray(map_replace, old_map_fds + 1,
882                                        sizeof(*map_replace));
883             if (!map_replace) {
884                     p_err("mem alloc failed");
885                     goto err_free_reuse_maps;
886             }

...
1019 err_free_reuse_maps:
1020         for (i = 0; i < old_map_fds; i++)
1021                 close(map_replace[i].fd);
1022         free(map_replace);

Fixes: 3ff5a4dc5d ("tools: bpftool: allow reuse of maps with bpftool prog load")
Co-developed-by: Wen Yang <wen.yang99@zte.com.cn>
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
2018-11-22 00:45:51 +01:00
..
bash-completion
Documentation tools: bpftool: update references to other man pages in documentation 2018-11-09 08:20:52 +01:00
.gitignore
btf_dumper.c
cfg.c
cfg.h
cgroup.c
common.c tools: bpftool: pass an argument to silence open_obj_pinned() 2018-11-09 08:20:52 +01:00
jit_disasm.c
json_writer.c
json_writer.h
main.c
main.h tools: bpftool: pass an argument to silence open_obj_pinned() 2018-11-09 08:20:52 +01:00
Makefile
map_perf_ring.c
map.c
net.c
netlink_dumper.c
netlink_dumper.h
perf.c
prog.c tools: bpftool: fix potential NULL pointer dereference in do_load 2018-11-22 00:45:51 +01:00
xlated_dumper.c
xlated_dumper.h