Eric Dumazet d7ce369243 dump_stack: avoid potential deadlocks ... Some servers experienced fatal deadlocks because of a combination of bugs, leading to multiple cpus calling dump_stack(). The checksumming bug was fixed in commit 34ae6a1aa0 ("ipv6: update skb->csum when CE mark is propagated"). The second problem is a faulty locking in dump_stack() CPU1 runs in process context and calls dump_stack(), grabs dump_lock. CPU2 receives a TCP packet under softirq, grabs socket spinlock, and call dump_stack() from netdev_rx_csum_fault(). dump_stack() spins on atomic_cmpxchg(&dump_lock, -1, 2), since dump_lock is owned by CPU1 While dumping its stack, CPU1 is interrupted by a softirq, and happens to process a packet for the TCP socket locked by CPU2. CPU1 spins forever in spin_lock() : deadlock Stack trace on CPU1 looked like : NMI backtrace for cpu 1 RIP: _raw_spin_lock+0x25/0x30 ... Call Trace: <IRQ> tcp_v6_rcv+0x243/0x620 ip6_input_finish+0x11f/0x330 ip6_input+0x38/0x40 ip6_rcv_finish+0x3c/0x90 ipv6_rcv+0x2a9/0x500 process_backlog+0x461/0xaa0 net_rx_action+0x147/0x430 __do_softirq+0x167/0x2d0 call_softirq+0x1c/0x30 do_softirq+0x3f/0x80 irq_exit+0x6e/0xc0 smp_call_function_single_interrupt+0x35/0x40 call_function_single_interrupt+0x6a/0x70 <EOI> printk+0x4d/0x4f printk_address+0x31/0x33 print_trace_address+0x33/0x3c print_context_stack+0x7f/0x119 dump_trace+0x26b/0x28e show_trace_log_lvl+0x4f/0x5c show_stack_log_lvl+0x104/0x113 show_stack+0x42/0x44 dump_stack+0x46/0x58 netdev_rx_csum_fault+0x38/0x3c __skb_checksum_complete_head+0x6e/0x80 __skb_checksum_complete+0x11/0x20 tcp_rcv_established+0x2bd5/0x2fd0 tcp_v6_do_rcv+0x13c/0x620 sk_backlog_rcv+0x15/0x30 release_sock+0xd2/0x150 tcp_recvmsg+0x1c1/0xfc0 inet_recvmsg+0x7d/0x90 sock_recvmsg+0xaf/0xe0 ___sys_recvmsg+0x111/0x3b0 SyS_recvmsg+0x5c/0xb0 system_call_fastpath+0x16/0x1b Fixes: b58d977432 ("dump_stack: serialize the output from dump_stack()") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Alex Thorlton <athorlton@sgi.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2016-02-05 18:10:40 -08:00
..
842	crypto: 842 - remove WARN inside printk	2015-12-23 18:20:01 +08:00
fonts
lz4
lzo
mpi
raid6
reed_solomon
xz
zlib_deflate
zlib_inflate
.gitignore
argv_split.c
asn1_decoder.c
assoc_array.c
atomic64_test.c	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2016-01-11 14:39:17 -08:00
atomic64.c
audit.c
bcd.c
bch.c
bitmap.c
bitrev.c
bsearch.c
btree.c
bug.c
build_OID_registry
bust_spinlocks.c
check_signature.c
checksum.c
clz_ctz.c
clz_tab.c
cmdline.c
compat_audit.c
cordic.c
cpu_rmap.c
cpu-notifier-error-inject.c
cpumask.c
crc-ccitt.c
crc-itu-t.c
crc-t10dif.c
crc7.c
crc8.c
crc16.c
crc32.c
crc32defs.h
ctype.c
debug_info.c
debug_locks.c
debugobjects.c	debugobjects: Allow bigger number of early boot objects	2016-01-27 15:40:59 +01:00
dec_and_lock.c
decompress_bunzip2.c
decompress_inflate.c
decompress_unlz4.c
decompress_unlzma.c
decompress_unlzo.c
decompress_unxz.c
decompress.c
devres.c
digsig.c
div64.c
dma-debug.c	dma-debug: switch check from _text to _stext	2016-01-14 16:00:49 -08:00
dump_stack.c	dump_stack: avoid potential deadlocks	2016-02-05 18:10:40 -08:00
dynamic_debug.c	convert a bunch of open-coded instances of memdup_user_nul()	2016-01-04 10:26:58 -05:00
dynamic_queue_limits.c
earlycpio.c
extable.c
fault-inject.c
fdt_empty_tree.c
fdt_ro.c
fdt_rw.c
fdt_strerror.c
fdt_sw.c
fdt_wip.c
fdt.c
find_bit.c
flex_array.c
flex_proportions.c
gcd.c
gen_crc32table.c
genalloc.c	CPM/QE: use genalloc to manage CPM/QE muram	2015-12-22 17:10:18 -06:00
glob.c
halfmd4.c
hexdump.c
hweight.c
idr.c
inflate.c
int_sqrt.c
interval_tree_test.c
interval_tree.c
iomap_copy.c	lib/iomap_copy.c: add __ioread32_copy()	2016-01-20 17:09:18 -08:00
iomap.c
iommu-common.c
iommu-helper.c
ioremap.c
iov_iter.c
irq_poll.c	irq_poll: Fix irq_poll_sched()	2016-01-19 15:26:55 -05:00
irq_regs.c
is_single_threaded.c
jedec_ddr_data.c
kasprintf.c	lib/kasprintf.c: add sanity check to kvasprintf	2016-01-16 11:17:27 -08:00
Kconfig	Initial roundup of 4.5 merge window patches	2016-01-23 18:45:06 -08:00
Kconfig.debug	Merge branch 'akpm' (patches from Andrew)	2016-01-21 12:32:08 -08:00
Kconfig.kasan
Kconfig.kgdb
Kconfig.kmemcheck
Kconfig.ubsan	UBSAN: run-time undefined behavior sanity checker	2016-01-20 17:09:18 -08:00
kfifo.c
klist.c
kobject_uevent.c
kobject.c
kstrtox.c
kstrtox.h
lcm.c
libcrc32c.c	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2016-01-22 11:58:43 -08:00
list_debug.c	mm, dax, pmem: introduce {get|put}_dev_pagemap() for dax-gup	2016-01-15 17:56:32 -08:00
list_sort.c
llist.c
locking-selftest-hardirq.h
locking-selftest-mutex.h
locking-selftest-rlock-hardirq.h
locking-selftest-rlock-softirq.h
locking-selftest-rlock.h
locking-selftest-rsem.h
locking-selftest-softirq.h
locking-selftest-spin-hardirq.h
locking-selftest-spin-softirq.h
locking-selftest-spin.h
locking-selftest-wlock-hardirq.h
locking-selftest-wlock-softirq.h
locking-selftest-wlock.h
locking-selftest-wsem.h
locking-selftest.c
lockref.c
lru_cache.c
Makefile	Initial roundup of 4.5 merge window patches	2016-01-23 18:45:06 -08:00
md5.c
memory-notifier-error-inject.c
memweight.c
net_utils.c
netdev-notifier-error-inject.c
nlattr.c
nmi_backtrace.c
notifier-error-inject.c
notifier-error-inject.h
of-reconfig-notifier-error-inject.c
oid_registry.c
once.c
parser.c
pci_iomap.c
percpu_counter.c
percpu_ida.c
percpu_test.c
percpu-refcount.c
plist.c
pm-notifier-error-inject.c
proportions.c
radix-tree.c	radix-tree: fix race in gang lookup	2016-02-03 08:28:43 -08:00
random32.c
ratelimit.c	ratelimit: fix bug in time interval by resetting right begin time	2016-01-21 17:20:51 -08:00
rational.c
rbtree_test.c
rbtree.c
reciprocal_div.c
rhashtable.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2015-12-31 18:20:10 -05:00
scatterlist.c
seq_buf.c	tracing: Use seq_buf_used() in seq_buf_to_user() instead of len	2015-12-23 14:27:20 -05:00
sg_split.c
sha1.c
show_mem.c
smp_processor_id.c
sort.c
stmp_device.c
string_helpers.c	string_helpers: fix precision loss for some inputs	2016-01-20 17:09:18 -08:00
string.c
strncpy_from_user.c
strnlen_user.c
swiotlb.c
syscall.c
test_bpf.c	bpf, test: add couple of test cases	2015-12-18 16:04:51 -05:00
test_firmware.c	test: firmware_class: add asynchronous request trigger	2016-01-07 13:44:22 -07:00
test_hexdump.c	test_hexdump: print statistics at the end	2016-01-20 17:09:18 -08:00
test_kasan.c
test_module.c
test_printf.c	lib/test_printf.c: test dentry printing	2016-01-16 11:17:29 -08:00
test_rhashtable.c
test_static_key_base.c
test_static_keys.c
test_user_copy.c
test-kstrtox.c
test-string_helpers.c	lib/test-string_helpers.c: fix and improve string_get_size() tests	2016-02-03 08:28:43 -08:00
textsearch.c
timerqueue.c
ts_bm.c
ts_fsm.c
ts_kmp.c
ubsan.c	UBSAN: run-time undefined behavior sanity checker	2016-01-20 17:09:18 -08:00
ubsan.h	UBSAN: run-time undefined behavior sanity checker	2016-01-20 17:09:18 -08:00
ucs2_string.c
usercopy.c
uuid.c
vsprintf.c	lib/vsprintf: factor out %pN[F] handler as netdev_bits()	2016-01-16 11:17:30 -08:00