AcoSail/llvm-project
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[TextAPI] Use const auto& in foreach loop to avoid pass-by-value static analyzer warnings. NFCI.

Browse Source
This commit is contained in:
Simon Pilgrim 2023-02-26 15:43:03 +00:00
parent 96aa76aa71
commit 35e21725e2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/TextAPI/TextStubV5.cpp
View File

@ -223,7 +223,7 @@ Error collectFromArray(TBDKey Key, const Object *Obj,
return Error::success();
}
for (Value Val : *Values) {
for (const Value &Val : *Values) {
auto ValStr = Val.getAsString();
if (!ValStr.has_value())
return make_error<JSONStubError>(getParseErrorMsg(Key));
@ -256,7 +256,7 @@ Expected<TargetList> getTargets(const Object *Section) {
return make_error<JSONStubError>(getParseErrorMsg(TBDKey::Targets));
TargetList IFTargets;
for (Value JSONTarget : *Targets) {
for (const Value &JSONTarget : *Targets) {
auto TargetStr = JSONTarget.getAsString();
if (!TargetStr.has_value())
return make_error<JSONStubError>(getParseErrorMsg(TBDKey::Target));