AcoSail/llvm-project
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundaunt virtual specifiers (NFC)

Browse Source 
Identified with tidy-modernize-use-override.
This commit is contained in:
Kazu Hirata 2022-07-25 23:00:59 -07:00
parent ae002f8bca
commit 3f3930a451
27 changed files with 74 additions and 84 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clang-tidy/bugprone/SharedPtrArrayMismatchCheck.h
View File

@ -28,7 +28,7 @@ public:
SharedPtrArrayMismatchCheck(StringRef Name, ClangTidyContext *Context);
protected:
virtual SmartPtrClassMatcher getSmartPointerClassMatcher() const override;
SmartPtrClassMatcher getSmartPointerClassMatcher() const override;
};
} // namespace bugprone

2
clang-tools-extra/clangd/AST.cpp
View File

@ -368,7 +368,7 @@ std::string printType(const QualType QT, const DeclContext &CurContext,
public:
PrintCB(const DeclContext *CurContext) : CurContext(CurContext) {}
virtual ~PrintCB() {}
virtual bool isScopeVisible(const DeclContext *DC) const override {
bool isScopeVisible(const DeclContext *DC) const override {
return DC->Encloses(CurContext);
}

2
clang-tools-extra/clangd/support/ThreadsafeFS.cpp
View File

@ -53,7 +53,7 @@ private:
assert(this->Wrapped);
}
virtual llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>>
llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>>
getBuffer(const llvm::Twine &Name, int64_t FileSize,
bool RequiresNullTerminator, bool /*IsVolatile*/) override {
return Wrapped->getBuffer(Name, FileSize, RequiresNullTerminator,

4
clang/lib/Basic/Targets/X86.h
View File

@ -229,12 +229,12 @@ public:
bool validateInputSize(const llvm::StringMap<bool> &FeatureMap,
StringRef Constraint, unsigned Size) const override;
virtual bool
bool
checkCFProtectionReturnSupported(DiagnosticsEngine &Diags) const override {
return true;
};
virtual bool
bool
checkCFProtectionBranchSupported(DiagnosticsEngine &Diags) const override {
return true;
};

23
clang/lib/CodeGen/CGOpenMPRuntimeGPU.h
View File

@ -186,17 +186,16 @@ public:
/// Emit call to void __kmpc_push_proc_bind(ident_t *loc, kmp_int32
/// global_tid, int proc_bind) to generate code for 'proc_bind' clause.
virtual void emitProcBindClause(CodeGenFunction &CGF,
llvm::omp::ProcBindKind ProcBind,
SourceLocation Loc) override;
void emitProcBindClause(CodeGenFunction &CGF,
llvm::omp::ProcBindKind ProcBind,
SourceLocation Loc) override;
/// Emits call to void __kmpc_push_num_threads(ident_t *loc, kmp_int32
/// global_tid, kmp_int32 num_threads) to generate code for 'num_threads'
/// clause.
/// \param NumThreads An integer value of threads.
virtual void emitNumThreadsClause(CodeGenFunction &CGF,
llvm::Value *NumThreads,
SourceLocation Loc) override;
void emitNumThreadsClause(CodeGenFunction &CGF, llvm::Value *NumThreads,
SourceLocation Loc) override;
/// This function ought to emit, in the general case, a call to
// the openmp runtime kmpc_push_num_teams. In NVPTX backend it is not needed
@ -300,12 +299,12 @@ public:
/// SimpleReduction Emit reduction operation only. Used for omp simd
/// directive on the host.
/// ReductionKind The kind of reduction to perform.
virtual void emitReduction(CodeGenFunction &CGF, SourceLocation Loc,
ArrayRef<const Expr *> Privates,
ArrayRef<const Expr *> LHSExprs,
ArrayRef<const Expr *> RHSExprs,
ArrayRef<const Expr *> ReductionOps,
ReductionOptionsTy Options) override;
void emitReduction(CodeGenFunction &CGF, SourceLocation Loc,
ArrayRef<const Expr *> Privates,
ArrayRef<const Expr *> LHSExprs,
ArrayRef<const Expr *> RHSExprs,
ArrayRef<const Expr *> ReductionOps,
ReductionOptionsTy Options) override;
/// Returns specified OpenMP runtime function for the current OpenMP
/// implementation. Specialized for the NVPTX device.

2
clang/lib/CodeGen/MicrosoftCXXABI.cpp
View File

@ -782,7 +782,7 @@ public:
LoadVTablePtr(CodeGenFunction &CGF, Address This,
const CXXRecordDecl *RD) override;
virtual bool
bool
isPermittedToBeHomogeneousAggregate(const CXXRecordDecl *RD) const override;
private:

6
clang/lib/Sema/Sema.cpp
View File

@ -137,9 +137,9 @@ public:
void reset() { S = nullptr; }
virtual void FileChanged(SourceLocation Loc, FileChangeReason Reason,
SrcMgr::CharacteristicKind FileType,
FileID PrevFID) override {
void FileChanged(SourceLocation Loc, FileChangeReason Reason,
SrcMgr::CharacteristicKind FileType,
FileID PrevFID) override {
if (!S)
return;
switch (Reason) {

6
clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
View File

@ -55,9 +55,9 @@ public:
ID.AddPointer(getTag());
}
virtual PathDiagnosticPieceRef
VisitNode(const ExplodedNode *N, BugReporterContext &BRC,
PathSensitiveBugReport &BR) override;
PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
BugReporterContext &BRC,
PathSensitiveBugReport &BR) override;
// FIXME: Scan the map once in the visitor's constructor and do a direct
// lookup by region.

11
clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
View File

@ -852,9 +852,8 @@ protected:
return false;
}
virtual bool
wasModifiedInFunction(const ExplodedNode *CallEnterN,
const ExplodedNode *CallExitEndN) override {
bool wasModifiedInFunction(const ExplodedNode *CallEnterN,
const ExplodedNode *CallExitEndN) override {
if (!doesFnIntendToHandleOwnership(
CallExitEndN->getFirstPred()->getLocationContext()->getDecl(),
CallExitEndN->getState()->getAnalysisManager().getASTContext()))
@ -885,7 +884,7 @@ protected:
"later deallocation");
}
virtual PathDiagnosticPieceRef
PathDiagnosticPieceRef
maybeEmitNoteForObjCSelf(PathSensitiveBugReport &R,
const ObjCMethodCall &Call,
const ExplodedNode *N) override {
@ -893,7 +892,7 @@ protected:
return nullptr;
}
virtual PathDiagnosticPieceRef
PathDiagnosticPieceRef
maybeEmitNoteForCXXThis(PathSensitiveBugReport &R,
const CXXConstructorCall &Call,
const ExplodedNode *N) override {
@ -901,7 +900,7 @@ protected:
return nullptr;
}
virtual PathDiagnosticPieceRef
PathDiagnosticPieceRef
maybeEmitNoteForParameters(PathSensitiveBugReport &R, const CallEvent &Call,
const ExplodedNode *N) override {
// TODO: Factor the logic of "what constitutes as an entity being passed

5
clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp
View File

@ -530,9 +530,8 @@ public:
private:
/// \return Whether \c RegionOfInterest was modified at \p CurrN compared to
/// the value it holds in \p CallExitBeginN.
virtual bool
wasModifiedBeforeCallExit(const ExplodedNode *CurrN,
const ExplodedNode *CallExitBeginN) override;
bool wasModifiedBeforeCallExit(const ExplodedNode *CurrN,
const ExplodedNode *CallExitBeginN) override;
/// Attempts to find the region of interest in a given record decl,
/// by either following the base classes or fields.

2
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
View File

@ -198,7 +198,7 @@ public:
SDAGSwitchLowering(SelectionDAGBuilder *sdb, FunctionLoweringInfo &funcinfo)
: SwitchCG::SwitchLowering(funcinfo), SDB(sdb) {}
virtual void addSuccessorWithProb(
void addSuccessorWithProb(
MachineBasicBlock *Src, MachineBasicBlock *Dst,
BranchProbability Prob = BranchProbability::getUnknown()) override {
SDB->addSuccessorWithProb(Src, Dst, Prob);

5
llvm/lib/MC/ELFObjectWriter.cpp
View File

@ -293,9 +293,8 @@ public:
: ELFObjectWriter(std::move(MOTW)), OS(OS), DwoOS(DwoOS),
IsLittleEndian(IsLittleEndian) {}
virtual bool checkRelocation(MCContext &Ctx, SMLoc Loc,
const MCSectionELF *From,
const MCSectionELF *To) override {
bool checkRelocation(MCContext &Ctx, SMLoc Loc, const MCSectionELF *From,
const MCSectionELF *To) override {
if (isDwoSection(*From)) {
Ctx.reportError(Loc, "A dwo section may not contain relocations");
return false;

4
llvm/lib/Target/Mips/MipsPreLegalizerCombiner.cpp
View File

@ -31,8 +31,8 @@ public:
: CombinerInfo(/*AllowIllegalOps*/ true, /*ShouldLegalizeIllegal*/ false,
/*LegalizerInfo*/ nullptr, /*EnableOpt*/ false,
/*EnableOptSize*/ false, /*EnableMinSize*/ false) {}
virtual bool combine(GISelChangeObserver &Observer, MachineInstr &MI,
MachineIRBuilder &B) const override;
bool combine(GISelChangeObserver &Observer, MachineInstr &MI,
MachineIRBuilder &B) const override;
};
bool MipsPreLegalizerCombinerInfo::combine(GISelChangeObserver &Observer,

12
llvm/lib/Target/RISCV/RISCVInstrInfo.h
View File

@ -149,17 +149,15 @@ public:
std::vector<outliner::Candidate> &RepeatedSequenceLocs) const override;
// Return if/how a given MachineInstr should be outlined.
virtual outliner::InstrType
getOutliningType(MachineBasicBlock::iterator &MBBI,
unsigned Flags) const override;
outliner::InstrType getOutliningType(MachineBasicBlock::iterator &MBBI,
unsigned Flags) const override;
// Insert a custom frame for outlined functions.
virtual void
buildOutlinedFrame(MachineBasicBlock &MBB, MachineFunction &MF,
const outliner::OutlinedFunction &OF) const override;
void buildOutlinedFrame(MachineBasicBlock &MBB, MachineFunction &MF,
const outliner::OutlinedFunction &OF) const override;
// Insert a call to an outlined function into a given basic block.
virtual MachineBasicBlock::iterator
MachineBasicBlock::iterator
insertOutlinedCall(Module &M, MachineBasicBlock &MBB,
MachineBasicBlock::iterator &It, MachineFunction &MF,
outliner::Candidate &C) const override;

2
llvm/lib/Target/X86/X86InstrInfo.h
View File

@ -544,7 +544,7 @@ public:
ArrayRef<std::pair<unsigned, const char *>>
getSerializableDirectMachineOperandTargetFlags() const override;
virtual outliner::OutlinedFunction getOutliningCandidateInfo(
outliner::OutlinedFunction getOutliningCandidateInfo(
std::vector<outliner::Candidate> &RepeatedSequenceLocs) const override;
bool isFunctionSafeToOutlineFrom(MachineFunction &MF,

10
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
View File

@ -4500,9 +4500,8 @@ struct AAAlignImpl : AAAlign {
// to avoid making the alignment explicit if it did not improve.
/// See AbstractAttribute::getDeducedAttributes
virtual void
getDeducedAttributes(LLVMContext &Ctx,
SmallVectorImpl<Attribute> &Attrs) const override {
void getDeducedAttributes(LLVMContext &Ctx,
SmallVectorImpl<Attribute> &Attrs) const override {
if (getAssumedAlign() > 1)
Attrs.emplace_back(
Attribute::getWithAlignment(Ctx, Align(getAssumedAlign())));
@ -4972,9 +4971,8 @@ struct AANoCaptureImpl : public AANoCapture {
ChangeStatus updateImpl(Attributor &A) override;
/// see AbstractAttribute::isAssumedNoCaptureMaybeReturned(...).
virtual void
getDeducedAttributes(LLVMContext &Ctx,
SmallVectorImpl<Attribute> &Attrs) const override {
void getDeducedAttributes(LLVMContext &Ctx,
SmallVectorImpl<Attribute> &Attrs) const override {
if (!isAssumedNoCaptureMaybeReturned())
return;

7
llvm/lib/Transforms/InstCombine/InstCombineInternal.h
View File

@ -597,10 +597,9 @@ public:
/// demanded bits.
bool SimplifyDemandedInstructionBits(Instruction &Inst);
virtual Value *
SimplifyDemandedVectorElts(Value *V, APInt DemandedElts, APInt &UndefElts,
unsigned Depth = 0,
bool AllowMultipleUsers = false) override;
Value *SimplifyDemandedVectorElts(Value *V, APInt DemandedElts,
APInt &UndefElts, unsigned Depth = 0,
bool AllowMultipleUsers = false) override;
/// Canonicalize the position of binops relative to shufflevector.
Instruction *foldVectorBinop(BinaryOperator &Inst);

7
polly/include/polly/CodeGen/BlockGenerators.h
View File

@ -974,7 +974,7 @@ private:
/// @param BBMap A mapping from old values to their new values in this block.
/// @param LTS A mapping from loops virtual canonical induction variable to
/// their new values.
virtual void
void
generateScalarStores(ScopStmt &Stmt, LoopToScevMapT &LTS, ValueMapT &BBMAp,
__isl_keep isl_id_to_ast_expr *NewAccesses) override;
@ -988,9 +988,8 @@ private:
/// @param BBMap A mapping from old values to their new values
/// (for values recalculated within this basic block).
/// @param LTS A map from old loops to new induction variables as SCEVs.
virtual void copyPHIInstruction(ScopStmt &Stmt, PHINode *Inst,
ValueMapT &BBMap,
LoopToScevMapT &LTS) override;
void copyPHIInstruction(ScopStmt &Stmt, PHINode *Inst, ValueMapT &BBMap,
LoopToScevMapT &LTS) override;
};
} // namespace polly
#endif

2
polly/include/polly/CodeGen/LoopGeneratorsGOMP.h
View File

@ -47,7 +47,7 @@ public:
void deployParallelExecution(Function *SubFn, Value *SubFnParam, Value *LB,
Value *UB, Value *Stride) override;
virtual Function *prepareSubFnDefinition(Function *F) const override;
Function *prepareSubFnDefinition(Function *F) const override;
std::tuple<Value *, Function *> createSubFn(Value *Stride, AllocaInst *Struct,
SetVector<Value *> UsedValues,

2
polly/include/polly/CodeGen/LoopGeneratorsKMP.h
View File

@ -73,7 +73,7 @@ public:
void deployParallelExecution(Function *SubFn, Value *SubFnParam, Value *LB,
Value *UB, Value *Stride) override;
virtual Function *prepareSubFnDefinition(Function *F) const override;
Function *prepareSubFnDefinition(Function *F) const override;
std::tuple<Value *, Function *> createSubFn(Value *Stride, AllocaInst *Struct,
SetVector<Value *> UsedValues,

2
polly/include/polly/ScopPass.h
View File

@ -175,7 +175,7 @@ protected:
/// getAnalysisUsage - Subclasses that override getAnalysisUsage
/// must call this.
///
virtual void getAnalysisUsage(AnalysisUsage &AU) const override;
void getAnalysisUsage(AnalysisUsage &AU) const override;
private:
bool runOnRegion(Region *R, RGPassManager &RGM) override;

8
polly/lib/CodeGen/CodegenCleanup.cpp
View File

@ -40,9 +40,9 @@ public:
/// @name FunctionPass interface
//@{
virtual void getAnalysisUsage(llvm::AnalysisUsage &AU) const override {}
void getAnalysisUsage(llvm::AnalysisUsage &AU) const override {}
virtual bool doInitialization(Module &M) override {
bool doInitialization(Module &M) override {
assert(!FPM);
FPM = new llvm::legacy::FunctionPassManager(&M);
@ -106,7 +106,7 @@ public:
return FPM->doInitialization();
}
virtual bool doFinalization(Module &M) override {
bool doFinalization(Module &M) override {
bool Result = FPM->doFinalization();
delete FPM;
@ -115,7 +115,7 @@ public:
return Result;
}
virtual bool runOnFunction(llvm::Function &F) override {
bool runOnFunction(llvm::Function &F) override {
if (!F.hasFnAttribute("polly-optimized")) {
LLVM_DEBUG(
dbgs() << F.getName()

4
polly/lib/Support/DumpFunctionPass.cpp
View File

@ -100,11 +100,11 @@ public:
/// @name FunctionPass interface
//@{
virtual void getAnalysisUsage(llvm::AnalysisUsage &AU) const override {
void getAnalysisUsage(llvm::AnalysisUsage &AU) const override {
AU.setPreservesAll();
}
virtual bool runOnFunction(llvm::Function &F) override {
bool runOnFunction(llvm::Function &F) override {
runDumpFunction(F, Suffix);
return false;
}

4
polly/lib/Support/DumpModulePass.cpp
View File

@ -71,11 +71,11 @@ public:
/// @name ModulePass interface
//@{
virtual void getAnalysisUsage(llvm::AnalysisUsage &AU) const override {
void getAnalysisUsage(llvm::AnalysisUsage &AU) const override {
AU.setPreservesAll();
}
virtual bool runOnModule(llvm::Module &M) override {
bool runOnModule(llvm::Module &M) override {
runDumpModule(M, Filename, IsSuffix);
return false;
}

8
polly/lib/Transform/DeLICM.cpp
View File

@ -1428,13 +1428,13 @@ public:
static char ID;
explicit DeLICMWrapperPass() : ScopPass(ID) {}
virtual void getAnalysisUsage(AnalysisUsage &AU) const override {
void getAnalysisUsage(AnalysisUsage &AU) const override {
AU.addRequiredTransitive<ScopInfoRegionPass>();
AU.addRequired<LoopInfoWrapperPass>();
AU.setPreservesAll();
}
virtual bool runOnScop(Scop &S) override {
bool runOnScop(Scop &S) override {
// Free resources for previous scop's computation, if not yet done.
releaseMemory();
@ -1444,7 +1444,7 @@ public:
return Impl->isModified();
}
virtual void printScop(raw_ostream &OS, Scop &S) const override {
void printScop(raw_ostream &OS, Scop &S) const override {
if (!Impl)
return;
assert(Impl->getScop() == &S);
@ -1453,7 +1453,7 @@ public:
Impl->print(OS);
}
virtual void releaseMemory() override { Impl.reset(); }
void releaseMemory() override { Impl.reset(); }
};
char DeLICMWrapperPass::ID;

8
polly/lib/Transform/FlattenSchedule.cpp
View File

@ -47,12 +47,12 @@ public:
static char ID;
explicit FlattenSchedule() : ScopPass(ID) {}
virtual void getAnalysisUsage(AnalysisUsage &AU) const override {
void getAnalysisUsage(AnalysisUsage &AU) const override {
AU.addRequiredTransitive<ScopInfoRegionPass>();
AU.setPreservesAll();
}
virtual bool runOnScop(Scop &S) override {
bool runOnScop(Scop &S) override {
// Keep a reference to isl_ctx to ensure that it is not freed before we free
// OldSchedule.
IslCtx = S.getSharedIslCtx();
@ -79,7 +79,7 @@ public:
return false;
}
virtual void printScop(raw_ostream &OS, Scop &S) const override {
void printScop(raw_ostream &OS, Scop &S) const override {
OS << "Schedule before flattening {\n";
printSchedule(OS, OldSchedule, 4);
OS << "}\n\n";
@ -89,7 +89,7 @@ public:
OS << "}\n";
}
virtual void releaseMemory() override {
void releaseMemory() override {
OldSchedule = {};
IslCtx.reset();
}

8
polly/lib/Transform/Simplify.cpp
View File

@ -762,13 +762,13 @@ public:
explicit SimplifyWrapperPass(int CallNo = 0) : ScopPass(ID), CallNo(CallNo) {}
virtual void getAnalysisUsage(AnalysisUsage &AU) const override {
void getAnalysisUsage(AnalysisUsage &AU) const override {
AU.addRequiredTransitive<ScopInfoRegionPass>();
AU.addRequired<LoopInfoWrapperPass>();
AU.setPreservesAll();
}
virtual bool runOnScop(Scop &S) override {
bool runOnScop(Scop &S) override {
LoopInfo *LI = &getAnalysis<LoopInfoWrapperPass>().getLoopInfo();
Impl.emplace(CallNo);
@ -777,12 +777,12 @@ public:
return false;
}
virtual void printScop(raw_ostream &OS, Scop &S) const override {
void printScop(raw_ostream &OS, Scop &S) const override {
if (Impl)
Impl->printScop(OS, S);
}
virtual void releaseMemory() override { Impl.reset(); }
void releaseMemory() override { Impl.reset(); }
};
char SimplifyWrapperPass::ID;