AcoSail/llvm-project
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[lld-macho] Ignore -debug_variant flag

Browse Source 
As far as I can tell all this flag does in ld64 is warn about cases
where you're building dylibs that are going to be part of the shared
cache, which I assume only apple is doing. Strangely I have seen this
flag being passed in the wild so this silences the warning about it.

Differential Revision: https://reviews.llvm.org/D145200
This commit is contained in:
Keith Smiley 2023-03-02 15:05:19 -08:00
parent 657f60a07b
commit ea32351fae
No known key found for this signature in database
GPG Key ID: 33BA60D44C7167F8
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lld/MachO/Options.td
View File

@ -687,10 +687,6 @@ def no_warn_inits : Flag<["-"], "no_warn_inits">,
HelpText<"Suppress warnings for static initializers in the output">,
Flags<[HelpHidden]>,
Group<grp_rare>;
def debug_variant : Flag<["-"], "debug_variant">,
HelpText<"Suppress warnings germane to binaries shipping to customers">,
Flags<[HelpHidden]>,
Group<grp_rare>;
def unaligned_pointers : Separate<["-"], "unaligned_pointers">,
MetaVarName<"<treatment>">,
HelpText<"Handle unaligned pointers in __DATA segments according to <treatment>: warning, error, or suppress (default for arm64e is error, otherwise suppress)">,
@ -1387,3 +1383,7 @@ def objc_abi_version : Separate<["-"], "objc_abi_version">,
HelpText<"This option only applies to i386 in ld64">,
Flags<[HelpHidden]>,
Group<grp_ignored_silently>;
def debug_variant : Flag<["-"], "debug_variant">,
HelpText<"Do not warn about issues that are only problems for binaries shipping to customers.">,
Flags<[HelpHidden]>,
Group<grp_ignored_silently>;

2
lld/test/MachO/silent-ignore.s
View File

@ -20,7 +20,7 @@
## Check that we don't emit any warnings nor errors for these unimplemented flags.
# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
# RUN: %lld %t.o -o /dev/null -objc_abi_version 2
# RUN: %lld %t.o -o /dev/null -objc_abi_version 2 -debug_variant
.globl _main
_main: